-
Notifications
You must be signed in to change notification settings - Fork 52
chore(cloudflare): add /docs worker (poc) #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
dcramer
commented
Sep 8, 2025
- Update Cloudflare docs: deployment and overview
- Add turbo config for mcp-cloudflare
- Update wrangler and vite configs
- Adjust Cloudflare server types and index
- Update MCP prompts and resources definitions
- Refresh deploy and smoke-test workflows
- Update package manifests and lockfile
- Add docs package scaffold
- Update smoke tests
…ions - Update Cloudflare docs: deployment and overview - Add turbo config for mcp-cloudflare - Update wrangler and vite configs - Adjust Cloudflare server types and index - Update MCP prompts and resources definitions - Refresh deploy and smoke-test workflows - Update package manifests and lockfile - Add docs package scaffold - Update smoke tests Co-Authored-By: Codex CLI Agent <[email protected]>
|
im not convinced this is the simplest path forward. I took this prototype much farther and honestly it gets super complex. hyp[othetically it makes a lot of sense to abstract things into diff workers, but in this case, for example, we probably would want ALL UI (at minimum) to be in one worker. we could easily abstract the mcp service into its own worker, which actually would be of some value, but even that creates a bunch of packaging complexity. i will probably hold on this and reconsider later. |
| if [ "$STATUS" -ne 200 ]; then | ||
| echo "Unexpected status: $STATUS"; cat /tmp/docs_canary.html; exit 1; fi | ||
| if ! grep -q "<title>Documentation" /tmp/docs_canary.html; then | ||
| echo "Title check failed"; cat /tmp/docs_canary.html; exit 1; fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: HTML Title Mismatch Blocks Deployments
The docs worker's HTML title in packages/docs/client/index.html is <title>Sentry MCP Docs</title>. However, the deploy workflow and smoke tests expect <title>Documentation. This mismatch causes docs canary and production smoke tests to fail, blocking deployments and triggering rollbacks.
Additional Locations (2)
| "dev": { | ||
| "port": 8791 | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.