fix: Typo on release branch name for assembling image #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wonder how the release pipeline is not broken after all this.
markstory
approved these changes
Oct 20, 2025
Collaborator
Author
|
@markstory can you retry the failing GHA jobs? |
| assemble-taskbroker-image: | ||
| runs-on: ubuntu-latest | ||
| needs: [build] | ||
| if: ${{ (github.ref_name == 'main' || startsWith(github.ref_name, 'releases/')) && github.event_name != 'pull_request' }} |
Member
There was a problem hiding this comment.
Looks like the commit sha for release is the same as merge to main, which is why it doesn't break. This is probably because there is no pre release command for craft. If that's the case we don't even need to run assemble step on release branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wonder how the release pipeline is not broken after all this.