Big refactor: flatten CLI #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18720397497Details
💛 - Coveralls |
mephenor
reviewed
Oct 22, 2025
mephenor
approved these changes
Oct 22, 2025
| await downloader.download_file( | ||
| output_path=file_info.path_during_download, part_size=CONFIG.part_size | ||
| ) | ||
| with handle_download_errors(file_info): |
There was a problem hiding this comment.
Quick nitpick:
file_id has already been extracted in L. 150, no need to pass the whole object along just to get the ID into the log messages
There was a problem hiding this comment.
Ah yeah you're right, not sure what I saw. I will take it out as part of the next ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flattened and organized the CLI/Main/Downloader chain.
Will move on to upload path after this PR because remaining refactoring items are not critical.