C#: Update to .NET SDK 9.0.300 and .NET Runtime 9.0.5. #20352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/dotnet908
branch
from
f332ec3 to
bf032af
Compare
michaelnebel
changed the title
michaelnebel
force-pushed
the
csharp/dotnet908
branch
2 times, most recently
from
1cfa066 to
38cdd22
Compare
michaelnebel
force-pushed
the
csharp/dotnet908
branch
3 times, most recently
from
4079db7 to
9a97fb0
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR updates the C# extractor to use .NET SDK 9.0.300 (and .NET Runtime 9.0.5) for improved stability on action runners with .NET Runtime 9.0.8 installed.
Key changes:
- Updates the C# extractor to use .NET SDK 9.0.300 and Runtime 9.0.5
- Updates most integration tests to use .NET SDK 9.0.304
- Adds file filtering functionality to avoid packaging issues with localized files
Reviewed Changes
Copilot reviewed 57 out of 57 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| misc/bazel/csharp.bzl | Adds file filtering rule and updates binary packaging logic |
| csharp/scripts/stubs/helpers.py | Updates SDK version from 9.0.100 to 9.0.300 |
| csharp/scripts/create-extractor-pack.sh | Updates runtime version from 9.0.0 to 9.0.5 |
| Various global.json files | Updates SDK versions to 9.0.304 for integration tests |
| Various .expected files | Updates assembly references to reflect new .NET versions |
michaelnebel
force-pushed
the
csharp/dotnet908
branch
4 times, most recently
from
f9b38d4 to
6a2c959
Compare
A `publish` directory for a C# binary contains copies of some DLLs inside localized subdirectories (e.g. `ru`). We want to ignore those, as otherwise our packaging machinery now goes haywire, with the newer version of `rules_csharp`. In any case we never shipped those.
michaelnebel
force-pushed
the
csharp/dotnet908
branch
from
6a2c959 to
a0f8b58
Compare
hvitved
approved these changes
Sep 10, 2025
| @@ -0,0 +1,57 @@ | |||
| "rules_dotnet" | |||
There was a problem hiding this comment.
Is this a patched version of rules_dotnet?
There was a problem hiding this comment.
It is my understanding that in this file we create version 0.19.2-codeql.1 of rules_dotnet, where source.json specifies that we should apply the patch in misc/bazel/registry/modules/rules_dotnet/0.19.2-codeql.1/patches/revert_additional_files_in_nuget_archive.patch. However, I don't have any real understanding of the Bazel eco system (cc. @redsun82 ).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we update
rules_dotnet0.19.2.We hope that this will make test execution and extraction "more stable" on actions runners with .NET Runtime 9.0.8 installed.