Go: Support for MaD barriers and barrier guards. #21015
Draft
+423
−299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| pragma[noinline] | ||
| private predicate guards(Node g, ControlFlow::ConditionGuardNode guard, Node nd, SsaWithFields ap) { | ||
| guards(g, guard, nd) and nd = ap.getAUse() | ||
| private predicate guards( |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
aschackmull
force-pushed
the
go/mad-barriers
branch
2 times, most recently
from
70bdb01 to
66ec419
Compare
aschackmull
force-pushed
the
go/mad-barriers
branch
from
66ec419 to
10a0530
Compare
owen-mc
force-pushed
the
go/mad-barriers
branch
from
10a0530 to
0539b18
Compare
Contributor
|
Now that #21011 is merged I've rebased this and added commits to convert all the easily-convertible barriers and barrier guards to MaD. After running DCA I think this could be merged (without a change note). |
It used to pass even without ErrorSanitizer because `cookie` is already sanitized.
owen-mc
force-pushed
the
go/mad-barriers
branch
from
0539b18 to
82e1eb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.