Panic if InitiateHeartbeat exhausts retries to avoid looping infinitely #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on experience, if the writer database fails inbeetween the copy & cutover stages (e.g. during cutover pause), the heartbeat writes will fail and stop, then leading to throttled state and an infinite loop of throttler.shouldThrottle(). Since this state is irrecoverable, make the heartbeat writer panic if retries are exhausted, so that the migration can fail and be restarted later.
* add sysbench localtest * fix table name * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * ensure cleanup --------- Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a panic mechanism to prevent infinite looping when heartbeat injection fails repeatedly in the gh-ost migration tool. The change ensures that if the InitiateHeartbeat function exhausts its retry attempts, it will trigger a panic abort instead of continuing indefinitely.
- Adds panic abort mechanism when heartbeat injection fails after maximum retry attempts
- Provides detailed error information including failure count and last encountered error
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
thesnowrose
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge @grodowski's fix #1574.
Closes #1569