Skip to content

fix: add "alt" to images and "aria-label" to buttons in index page #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: add "alt" to images and "aria-label" to buttons in index page #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1063588
fix: add "alt" to images and "aria-label" to buttons
Edmar-Sousa Oct 6, 2025
873749d
fix: add empty "alt" to decorative image
Edmar-Sousa Oct 6, 2025
c9cc55b
Merge branch 'master' of github.com:Edmar-Sousa/hacktoberfest into fi…
Edmar-Sousa Oct 21, 2025
4861e8b
fix: add alt
Edmar-Sousa Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/come-to-globo/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ const ComeToGlobo = () => {
<Grid container className={classes.mainContent} spacing={4} direction="row" alignItems="center" justifyContent="center">
<Grid item xs={12} md={6} className={classes.rightColumn}>
<Box className={classes.hexagonContainer}>
<Image src="2025/challenge.svg" className={classes.challengeImage} />
<Image src="2025/challenge.svg" className={classes.challengeImage} alt="Temos desafios para você" />
</Box>
</Grid>
<Grid item xs={12} md={6} className={classes.leftColumn}>
Expand Down
8 changes: 4 additions & 4 deletions src/components/footer/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ const FooterDesktop = (props: FooterItemsProps) => {
<Grid item>
<Grid container justifyContent="space-between" alignItems="center">
<Grid item>
<Image src="2025/globo.svg" width="166" height="48" />
<Image src="2025/globo.svg" alt="Logo da Globo" width="166" height="48" />
</Grid>

<Grid item>
<Image src="2025/logo-footer.svg" width="256" height="138" />
<Image src="2025/logo-footer.svg" alt="Logo Hacktoberfest 2025" width="256" height="138" />
</Grid>

<Grid item>
Expand Down Expand Up @@ -108,12 +108,12 @@ const FooterSmart = (props: FooterItemsProps) => {
>
<Spacing smart={{ margin: "10px 32px 0" }}>
<Grid item>
<Image height="30" src="2025/globo.svg" />
<Image height="30" src="2025/globo.svg" alt="Logo da Globo" />
</Grid>
</Spacing>
<Spacing smart={{ margin: "0 18px 0" }}>
<Grid item>
<Image src="2025/logo-footer.svg" with="278" height="90" />
<Image src="2025/logo-footer.svg" alt="Logo Hacktoberfest 2025" with="278" height="90" />
</Grid>
</Spacing>
{props.menuItems.map((item: MenuItem, i: number) => (
Expand Down
10 changes: 7 additions & 3 deletions src/components/hero/HeroDesktop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,16 +233,19 @@ const LoggedView = (user: UserProps) => {
<Image
className={state == 0 ? classes.active : ""}
src="hero/PR.svg"
alt=""
/>{" "}
{/** Ativo se Approved e Completed for false */}
<Image
className={state == 1 ? classes.active : ""}
src="hero/Check.svg"
alt=""
/>{" "}
{/** Ativo se Approved true e completed false */}
<Image
className={state == 2 ? classes.active : ""}
src="hero/Shirt.svg"
alt=""
/>{" "}
{/* Ativo se completed e aproved for true*/}
</div>
Expand Down Expand Up @@ -313,8 +316,8 @@ const DesktopView = (props: DesktopViewProps) => {
return (
<Grid container alignItems="center" className={classes.wrapper}>
<Grid item sm={4} className={classes.gridItem}>
<Image className={classes.logoGlobo} src={`2025/globo.svg`} />
<Image className={classes.logoEdition} src={`2025/home-logo.svg`} />
<Image className={classes.logoGlobo} src={`2025/globo.svg`} alt="Logo da Globo" />
<Image className={classes.logoEdition} src={`2025/home-logo.svg`} alt="Logo Hacktoberfest 2025" />
<Typography
variant="h1"
align="center"
Expand Down Expand Up @@ -361,11 +364,12 @@ const DesktopView = (props: DesktopViewProps) => {
<Image
className={classes.character}
src={`2025/ilustracao-home.svg`}
alt=""
/>
</Box>
</Grid>
<Grid item sm={4} className={classes.gridMessage}>
<Image className={classes.message} src={`2025/message.svg`} />
<Image className={classes.message} src={`2025/message.svg`} alt="Contribua e ganhe 1 camiseta exclusiva" />

{/* <div className={classes.droneAnimation2}>
<Lottie options={defaultOptions} height={300} width={350} />
Expand Down
6 changes: 3 additions & 3 deletions src/components/hero/HeroSmart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,9 +268,9 @@ const SmartView = (props: SmartViewProps) => {
justifyContent="center"
>
<Grid item sm={12}>
<Image className={classes.logoGlobo} src={`2024/globo.svg`} />
<Image className={classes.logoGlobo} src={`2024/globo.svg`} alt="Logo da Globo" />
<div className={classes.contentCenter}>
<Image className={classes.logoEdition} src={`2025/home-logo.svg`} />
<Image className={classes.logoEdition} src={`2025/home-logo.svg`} alt="Logo Hacktoberfest 2025" />
<Typography
variant="h1"
align="center"
Expand Down Expand Up @@ -306,7 +306,7 @@ const SmartView = (props: SmartViewProps) => {
</Grid>
<Grid item sm={6}></Grid>
<Grid item sm={4} className={classes.messageImage} >
<Image src={`2025/message.svg`} />
<Image src={`2025/message.svg`} alt="Contribua e ganhe 1 camiseta exclusiva" />
{/* <div className={classes.droneAnimation2}>
<Lottie
className={classes.drone}
Expand Down
3 changes: 2 additions & 1 deletion src/components/navigation/Navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,7 @@ const SmartMenu = () => {
</Grid>
<Grid item xs={2} md={1}>
<Button
aria-label="Abrir menu lateral"
style={{
display: "block",
float: "right",
Expand All @@ -227,7 +228,7 @@ const SmartMenu = () => {
}}
onClick={() => setMenuOpened(!menuOpened)}
>
<Image src="2025/menu.svg" />
<Image alt="" src="2025/menu.svg" />
</Button>
{menuOpened && <MenuOpen closeMenu={() => setMenuOpened(false)} />}
</Grid>
Expand Down
2 changes: 1 addition & 1 deletion src/components/projects/ProjectsList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ const ProjectsList = (props: ProjectListProps) => {

function ProjectsListLoading() {
return <Box display="flex" width="100%" justifyContent="center">
<CircularProgress />
<CircularProgress aria-label="Carregando projetos" aria-busy="true" />
</Box>
}

Expand Down
2 changes: 1 addition & 1 deletion src/components/scroll-top/ScrollTop.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const ScrollTop = () => {

return (
<div className={classes.scrollTop}>
<Image src="2023/scroll-top.svg" onClick={scrollToTop} />
<Image src="2023/scroll-top.svg" alt="Voltar para o topo" onClick={scrollToTop} />
</div>
)
}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ const IndexPage = () => {
</div>

<Grid container justifyContent="center" alignItems="center" className={classes.backgroundImageContainer}>
<Image src="2025/come-to-globo.svg" className={classes.backgroundImage} />
<Image src="2025/come-to-globo.svg" alt="Imagem vem pra Globo" className={classes.backgroundImage} />
</Grid>

<div>
Expand Down