Update setup.py #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Verification when reading the file
dmvieira
suggested changes
Oct 6, 2020
| if not req or req.startswith(('-e', '#')): | ||
| continue | ||
| install_requires.append(req) | ||
| except: |
There was a problem hiding this comment.
why do you need try except? The file should be always there
There was a problem hiding this comment.
In some situations the program is unable to read the file correctly, so the creation of the treatment, in case the error occurs
There was a problem hiding this comment.
but it needs requirement. Isn't it?
There was a problem hiding this comment.
Fair, but security is never too much
There was a problem hiding this comment.
but you can't install the plugin without requirements... this should raise exception instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification when reading the file