Vertical Cursor Guide#383

Open

ahelsley wants to merge 32 commits intognachman:masterfrom

ahelsley:vertical-cursor-guide

Commits on Mar 26, 2019

Render a vertical guide over the column the cursor is in (Metal View implementation).
Andrew Helsley
committed
Separate control of the vertical cursor guide from the horizontal guide.
Andrew Helsley
committed
Render a vertical cursor guide in the software rendered view (known issue: only renders on the 3 lines centered on the cursor).
Andrew Helsley
committed
Fill out cursor column tracking API.
Andrew Helsley
committed

Commits on Apr 2, 2019

Fix names and style inconsistencies.
Andrew Helsley
committed
Rename a couple more "col" variables to use full names.
Andrew Helsley
committed
Fix bug with variable name type ("...Line" should be "...Column"). Renamve vvertexBuffer into verticalGuideVertexBuffer. Finish separating out control over the horizontal cursor guide from the ve…
Andrew Helsley
committed

Commits on Apr 7, 2019

Commits on Apr 8, 2019

Do not double-draw the cursor guide under the cursor.
Andrew Helsley
committed

Commits on Apr 13, 2019

Render a vertical guide over the column the cursor is in (Metal View implementation).
Andrew Helsley
committed
Separate control of the vertical cursor guide from the horizontal guide.
Andrew Helsley
committed
Render a vertical cursor guide in the software rendered view.
Andrew Helsley
committed
Fill out cursor column tracking API.
Andrew Helsley
committed
Fix bug with variable name type ("...Line" should be "...Column"). Renamve vvertexBuffer into verticalGuideVertexBuffer. Finish separating out control over the horizontal cursor guide from the ve…
Andrew Helsley
committed
Remove extraneous shared vertex buffer in favor of keeping more in the cursor guide renderer. Create additional texture for vertical cursor guide. Create additional vertex buffers for vertical an…
Andrew Helsley
committed
Factor out rectangle tessellation and vertex buffer creation.
Andrew Helsley
committed
Use bounds from iTermCursorGuideRendererTransientState's cellConfiguration instead of requiring them to be passed into the method.
Andrew Helsley
committed
Since [...textView setNeedsDisplayOnColumn...] is expensive (causes a complete redraw), do not cause the redraw unless there is good reason to do so (ie the vertical cursor guide is enabled).
Andrew Helsley
committed
Do not double-draw the cursor guide under the cursor.
Andrew Helsley
committed
Fix style nits.
Andrew Helsley
committed
Fix rebase conflict.
Andrew Helsley
committed
Resolved conflicts with upstream branch.
Andrew Helsley
committed
Remove merge/conflict resolution detritus.
Andrew Helsley
committed
Remove unused variable that seems to be causing CI build fails.
Andrew Helsley
committed

Commits on Apr 18, 2019

Add ability to render a vertical guide over the column the cursor is in.
Andrew Helsley
committed
Merged with upstream branch
Andrew Helsley
committed
Remove code duplicated as a result of merge with upstream branch.
Andrew Helsley
committed
Disable code that references an undeclared identifier (brought in from master/HEAD during rebase?).
Andrew Helsley
committed