-
Notifications
You must be signed in to change notification settings - Fork 442
feat(gnokey): add missing -send flag to maketx run #4868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat(gnokey): add missing -send flag to maketx run #4868
Conversation
Closes gnolang#4866 Added a txtar test to ensure that -send flag doesnt affect the user balance when used in `maketx run`. Added similar txtar for `maketx call`, this time the user balance is affected.
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
notJoon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have needed this flag for a long time. 👍
Setup the required forked gno with: gnolang/gno#4868 tbruyelle/gno#1
Closes #4866
Required for #4655
Added a txtar test to ensure that -send flag doesnt affect the user balance when used in
maketx run.Added similar txtar for
maketx call, this time the user balance is affected.