-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Refactor CatFile batch implementation and introduce batch-command for git 2.36 #34651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f0b6480 to
334eb9e
Compare
|
It's ready to review again. |
|
Saw many flaky tests: |
dc7576a to
d318098
Compare
|
No easy fix unless rewrite more legacy code Do you have the determination to continue. |
095d622 to
a686188
Compare
e73929b to
751ccd0
Compare
751ccd0 to
533687c
Compare
44243e5 to
e7e9a04
Compare
731c2a4 to
9b89692
Compare
9b89692 to
2bd1873
Compare
f266926 to
6394d98
Compare
|
Give up. Old branch is saved at https://github.com/lunny/gitea/tree/lunny/catfile_batch_refactor-old , but it can't be merged because there are unclear random CI failures. Even I have rewritten from scratch by a simpler approach, the unclear random failure still exists. I have traced down the problem to
|
For git version 2.36,
git cat-file --batch-commandwas introduced which can replacegit cat-file --batchandgit cat-file --batch-check.This PR implements an abstract layer for the batch commands so that both git 2.36 and lower version git can work.
If git version is lower than 2.36, it will start two subprocesses
git cat-file --batchandgit cat-file --batch-check.If git version is greater than 2.36, only
git cat-file --batch-commandwill be started.This reduced half of child processes of git catfiles.