Enable logout redirection for reverse proxy setups #36052
+63
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
eliroca
force-pushed
the
logout_redirect
branch
from
d81b162 to
eb41ffc
Compare
When authentication is handled externally by a reverse proxy or SSO provider, users can be redirected to an external logout URL or relative path defined on the reverse proxy. The reverse proxy or SSO provider must redirect back to Gitea for terminating the local session.
eliroca
force-pushed
the
logout_redirect
branch
from
eb41ffc to
5e1923c
Compare
lunny
reviewed
Dec 1, 2025
| "MermaidMaxSourceCharacters": func() int { | ||
| return setting.MermaidMaxSourceCharacters | ||
| }, | ||
| "ReverseProxyLogoutRedirect": func() string { |
Member
There was a problem hiding this comment.
Use a global variable rather than a global function
delvh
reviewed
Dec 1, 2025
| ;; The external logout endpoint (reverse proxy / IdP) must then redirect | ||
| ;; the user back to /user/logout so Gitea can terminate its local session | ||
| ;; after the global SSO logout completes. | ||
| ;REVERSE_PROXY_LOGOUT_REDIRECT = /mellon/logout?ReturnTo=/user/logout |
Member
There was a problem hiding this comment.
I don't think it makes sense to hardcode one specific provider here in the default value.
If anything, write the path in the comment above as an example for Mellon (I guess?) and leave this value empty.
| } | ||
| HandleSignOut(ctx) | ||
| if ctx.Req.Method == http.MethodGet { | ||
| ctx.Redirect(setting.AppSubURL + "/") |
Member
There was a problem hiding this comment.
I don't understand the purpose of this extra GET.
Why can it suddenly be a GET?
And why can't it return JSON content?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When authentication is handled externally by a reverse proxy or SSO provider, users can be redirected to an external logout URL or relative path defined on the reverse proxy.
The reverse proxy or SSO provider must redirect back to Gitea for terminating the local session.