Skip to content

fix nilnil in onedev downloader #36154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
silverwind merged 4 commits into from
Dec 16, 2025
Merged

fix nilnil in onedev downloader #36154

silverwind merged 4 commits into from
Dec 16, 2025
+9 −9

Conversation

@TheFox0x7
Copy link
Contributor

@TheFox0x7 TheFox0x7 commented Dec 13, 2025 •
edited
Loading

onedev migration never used the migration transport, it now uses it the same way gogs one does

cuts 3 nilnils for #36152

@TheFox0x7
fix nilnil in oneDev downloader
81f4fc4 
Applies the same override as with gogs downloader
@TheFox0x7
ignore nilnil in cmd tests
e0eb6f6
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 13, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin labels Dec 13, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 14, 2025
@silverwind
Copy link
Member

silverwind commented Dec 14, 2025

I guess it's fine to place unused // nolint statements now, but later we should make the linter report unused directives, similar to eslint reportUnusedDisableDirectives, if such an option exists.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 14, 2025
@TheFox0x7
Copy link
Contributor Author

TheFox0x7 commented Dec 14, 2025

it does https://golangci-lint.run/docs/linters/configuration/#nolintlint and we have it on (in fact I added it)

gitea/.golangci.yml

Lines 18 to 20 in 1f5237e

- nakedret
- nolintlint
- perfsprint

gitea/.golangci.yml

Lines 49 to 52 in 1f5237e

nolintlint:
allow-unused: false
require-explanation: true
require-specific: true

I'm very confused why it didn't complain about the nolint here...

@silverwind
Copy link
Member

silverwind commented Dec 15, 2025 •
edited
Loading

Might be a bug in golangci-lint.

@silverwind silverwind enabled auto-merge (squash) December 16, 2025 01:46
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 16, 2025
@silverwind silverwind merged commit 3bb0770 into go-gitea:main Dec 16, 2025
23 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Dec 16, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees

No one assigned

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/cli PR changes something on the CLI, i.e. gitea doctor or gitea admin modifies/go Pull requests that update Go code

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

4 participants

@TheFox0x7 @silverwind @delvh @GiteaBot