Fix VehicleWheel3D sinking #112440
Open
Fix VehicleWheel3D sinking #112440
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Fix for both the issue and the problems with #47412 |
FuWan722
reviewed
Nov 8, 2025
FuWan722
left a comment
FuWan722
left a comment
There was a problem hiding this comment.
On line 488 and 496, both hitDistance and depth are param * raylen, but param is some length / raylen. Do you think we should just remove / raylen and *raylen?
Author
|
@FuWan722 I aimed at a minimum changelist. But yeah with some minor reshuffling of variables we could get rid of the extras. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45339
Before:
After: