Skip to content

Refactor flag count detection for PROPERTY_HINT_FLAGS #112456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Refactor flag count detection for PROPERTY_HINT_FLAGS #112456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions servers/rendering/instance_uniforms.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,17 +164,15 @@ void InstanceUniforms::_init_param(Item &r_item, const RendererMaterialStorage::
}

if (r_item.info.hint == PROPERTY_HINT_FLAGS) {
// HACK: Detect boolean flags count and prevent overhead.
switch (r_item.info.hint_string.length()) {
case 3: // "x,y"
r_item.flags = 1;
break;
case 5: // "x,y,z"
r_item.flags = 2;
break;
case 7: // "x,y,z,w"
r_item.flags = 3;
break;
if (r_item.info.hint == PROPERTY_HINT_FLAGS) {
const String &hint = r_item.info.hint_string;
if (!hint.is_empty()) {
int flag_count = hint.count(",") + 1;

r_item.flags = MAX(0, flag_count - 1);
} else {
r_item.flags = 0;
}
}
}
}
Expand Down
Loading