-
Notifications
You must be signed in to change notification settings - Fork 1.5k
YDB database support #1215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
YDB database support #1215
Conversation
YDB Support
|
@dhui Can you see this PR? We are waiting YDB support in golang-migrate very much |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for YDB (Yandex Database) to golang-migrate, implementing a complete database driver with migration capabilities, locking mechanisms, and comprehensive test coverage.
Key Changes:
- New YDB database driver with full migration lifecycle support (Open, Close, Lock, Unlock, Run, SetVersion, Version, Drop)
- Extensive test suite including integration tests with Docker containers
- Complete documentation with connection string format and configuration options
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
internal/cli/build_ydb.go |
Build tag configuration to conditionally include YDB driver in CLI builds |
go.mod / go.sum |
Added YDB SDK dependencies (v3.100.0) and related transitive dependencies |
database/ydb/ydb.go |
Main driver implementation with connection handling, migrations, versioning, and locking |
database/ydb/ydb_test.go |
Comprehensive test suite with Docker-based integration tests for multiple YDB versions |
database/ydb/examples/migrations/*.sql |
Example migrations demonstrating YDB-specific features (tables, columns, indexes, topics) |
database/ydb/README.md |
Detailed documentation covering connection strings, authentication methods, TLS options, and troubleshooting |
README.md |
Added YDB to the list of supported database drivers |
Makefile |
Added ydb to the DATABASE variable for build/test targets |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Added YDB support to golang-migrate
This PR implements support for YDB in golang-migrate. The main changes include:
How to Test: