-
Notifications
You must be signed in to change notification settings - Fork 3k
feat:Added Token Retrieve Feature Issue:#117 #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat:Added Token Retrieve Feature Issue:#117 #181
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @AbdulTawabJuly, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement by integrating a robust token usage tracking system throughout the application. The primary goal is to provide users with clear visibility into the token consumption of their Large Language Model (LLM) calls, thereby enabling better cost management and resource optimization. The changes span the backend to collect and store token data, the agent nodes to record usage during their operations, and both the frontend and CLI to present this information in an accessible and informative manner. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable token usage tracking feature, enhancing cost monitoring capabilities. The changes span across the backend, frontend, and CLI examples, providing a comprehensive implementation. The backend now tracks token usage per agent node, the frontend displays this information in a new collapsible UI component, and the CLI prints a summary.
My review highlights a few areas for improvement, primarily focused on maintainability and UI consistency. I've pointed out some code duplication in the backend that could be refactored, a hardcoded dependency in the frontend that could be made more robust, and some minor UI inconsistencies. Addressing these points will help improve the long-term quality of the codebase. Overall, this is a well-executed feature.
Feature
I added token counting so you can see how many tokens each LLM call uses. This helps you track API costs and understand what's eating up your budget.
Approach
I added token tracking to the state so it accumulates as the agent runs. Created some helper functions to pull token counts from the API responses.
Implementation