Skip to content

Conversation

@kinarr
Copy link
Contributor

@kinarr kinarr commented Nov 21, 2024

Update: Switched from Gemma 1.1 to 2

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@@ -0,0 +1,802 @@
{
Copy link
Collaborator

@windmaple windmaple Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why RAG is relevant here.


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in the library here
https://github.com/aniquetahir/JORA

@@ -0,0 +1,802 @@
{
Copy link
Collaborator

@windmaple windmaple Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #1.    VARIANT = "1.1-2b-it"

use Gemma2


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the library is compatible with it but will check

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@windmaple The directory structure needs to be modified manually for the time being until JORA's maintainer updates the repo to include Gemma 2 support

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update the notebook to use Gemma 2 but I figured it wouldn't be ideal as the library hasn't added support for it yet. It works nonetheless, but we need to alter the directory structure for the downloaded Flax model.

@windmaple
Copy link
Collaborator

windmaple commented Nov 21, 2024

Also does it crash for you on T4? It keeps crashing due to OOM (CPU)

Don't forget to update README/WISHLIST

@kinarr
Copy link
Contributor Author

kinarr commented Nov 21, 2024

Also does it crash for you on T4? It keeps crashing due to OOM (CPU)

Don't forget to update README/WISHLIST

I've mentioned in the notebook that it requires an A100 btw.

@kinarr
Copy link
Contributor Author

kinarr commented Nov 21, 2024

Also does it crash for you on T4? It keeps crashing due to OOM (CPU)

Don't forget to update README/WISHLIST

The library has no quantization support yet so we're expected to use a high-end GPU for the time being I believe.

- Add another prompt to test the model
@windmaple
Copy link
Collaborator

Also does it crash for you on T4? It keeps crashing due to OOM (CPU)
Don't forget to update README/WISHLIST

I've mentioned in the notebook that it requires an A100 btw.

T4 actually works fine. For some reason you need the high RAM instance. Could you try to figure out why?
Or at least we should point ppl to use Kaggle, which offers more CPU RAM on GPU VMs.

@kinarr
Copy link
Contributor Author

kinarr commented Nov 22, 2024

Also does it crash for you on T4? It keeps crashing due to OOM (CPU)
Don't forget to update README/WISHLIST

I've mentioned in the notebook that it requires an A100 btw.

T4 actually works fine. For some reason you need the high RAM instance. Could you try to figure out why? Or at least we should point ppl to use Kaggle, which offers more CPU RAM on GPU VMs.

Colab using the latest JAX version might be causing issues with the current JORA implementation. I'll investigate and verify if that's really the case.

@kinarr
Copy link
Contributor Author

kinarr commented Nov 22, 2024

Even on Kaggle it's hitting Colab's RAM limits (12.7 GB) so I believe it's best to direct free users to run it on Kaggle? @windmaple
image

…ilize JAX version

- Allow free-tier users to leverage two T4 GPUs on Kaggle
- Added the visibility and accessibility of Gemma 2 within the JORA library
- Lock the JAX library to the specific version used by Colab to ensure future compatibility and prevent potential issues arising from version discrepancies.
@windmaple
Copy link
Collaborator

Kaggle it is

@windmaple windmaple merged commit 6b789a6 into google-gemini:main Nov 26, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants