Skip to content

Conversation

@patrickcarnahan
Copy link

@patrickcarnahan patrickcarnahan commented Nov 12, 2025

fixes #3822

This adds the missing properties actor_controlled_merging and check_run_retries_limit to the merge queue rule configuration object. The new properties are added as omitempty to avoid behavioral changes for existing logic that may not be setting these values.

Happy to adjust course and remove omitempty and fix tests if that's the desired take.

@google-cla
Copy link

google-cla bot commented Nov 12, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@patrickcarnahan patrickcarnahan marked this pull request as ready for review November 12, 2025 20:40
@gmlewis gmlewis changed the title add missing mq config properties Add missing mq config properties Nov 12, 2025
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.32%. Comparing base (8657c38) to head (cb0f47b).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3823   +/-   ##
=======================================
  Coverage   92.32%   92.32%           
=======================================
  Files         194      194           
  Lines       13979    13979           
=======================================
  Hits        12906    12906           
  Misses        884      884           
  Partials      189      189           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmlewis gmlewis changed the title Add missing mq config properties Add missing MergeQueueRuleParameters config properties Nov 12, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @patrickcarnahan!
Once you make this changes, please run step 4 of CONTRIBUTING.md and push the changes to this PR.


// MergeQueueRuleParameters represents the merge_queue rule parameters.
type MergeQueueRuleParameters struct {
ActorControlledMerging bool `json:"actor_controlled_merging,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is an optional parameter, as indicated by the inclusion of omitempty, then this should be a *bool instead of a bool.

type MergeQueueRuleParameters struct {
ActorControlledMerging bool `json:"actor_controlled_merging,omitempty"`
CheckResponseTimeoutMinutes int `json:"check_response_timeout_minutes"`
CheckRunRetriesLimit int `json:"check_run_retries_limit,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. This should be *int instead of int.

@patrickcarnahan
Copy link
Author

@gmlewis thanks for the quick turnaround! unfortunately i should have done a little more research first as these properties are not documented nor are they available first repos. for those reasons i think the right thing to do is close this pr out for the time being.

thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add missing mergequeue rule configuration properties

2 participants