Implement Enterprise SCIM - EnterpriseService.ListProvisionedSCIMUsers #3839
Conversation
elminster-aom
left a comment
elminster-aom
left a comment
There was a problem hiding this comment.
Found an incoherence about the Accept header. While the document states for all endpoints:
Headers
acceptstring
Setting toapplication/vnd.github+jsonis recommended.
Their example endpoints use different values. For example on GET .../Users: -H "Accept: application/scim+json"
Reported to GitHub support and they confirmed that:
The correct header is
Accept: application/scim+json.
Fix here for EnterpriseService.ListProvisionedSCIMGroups
TODO
Fix for SCIMService endpoints too.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3839 +/- ##
=======================================
Coverage 92.41% 92.42%
=======================================
Files 197 197
Lines 14152 14167 +15
=======================================
+ Hits 13079 13094 +15
Misses 884 884
Partials 189 189 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gmlewis
left a comment
gmlewis
left a comment
There was a problem hiding this comment.
Thank you, @elminster-aom!
Just a few tweaks, please, then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
| Filter string `url:"filter,omitempty"` | ||
| // Used for pagination: the starting index of the first result to return when paginating through values. | ||
| // Default: 1. | ||
| StartIndex int `url:"startIndex,omitempty"` | ||
| // Used for pagination: the number of results to return per page. | ||
| // Default: 30. | ||
| Count int `url:"count,omitempty"` |
There was a problem hiding this comment.
These omitempty fields should be pointers since they are optional values.
2 participants
Related with #3813
Summary
From REST API endpoints for Enterprise SCIM docs, implements:
/scim/v2/enterprises/{enterprise}/GroupsOther changes
Enterprise.ListProvisionedSCIMGroupsAccept header, set it toapplication/scim+jsonEnterprise.ListProvisionedSCIMGroupsunti test function name