Update the toString() of some CharMatcher types.
#8083
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_828628927
branch
3 times, most recently
from
4c53323 to
fb622f3
Compare
copybara-service
bot
force-pushed
the
test_828628927
branch
from
fb622f3 to
c91bd2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
toString()of someCharMatchertypes.Most
toString()implementations mimic the code that could have produced the instance. Notably,someCharMatcher.negate()producessomeCharMatcher.toString() + ".negate()". But thetoString()for.andand.orused a syntax that made it look as if these were static methods rather than instance ones.Also update a couple of tests that depend on the exact
toString()output.RELNOTES=n/a