Skip to content

Conversation

@Jackxu9946
Copy link
Contributor

@Jackxu9946 Jackxu9946 commented Nov 10, 2025

Added windows support for gcloud-mcp.

Gcloud-mcp will automatically detect which OS it is being ran in and automatically choose the correct gcloud invocation command for the platform

Fixes #275

@Jackxu9946 Jackxu9946 requested a review from a team as a code owner November 10, 2025 19:07
@burkedavison burkedavison added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 11, 2025
@Jackxu9946 Jackxu9946 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 18, 2025
@Jackxu9946 Jackxu9946 changed the title FEAT: Fix Windows Platform Compatibility Issue FEAT: Support Windows OS for gcloud-mcp Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 94.66019% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.25%. Comparing base (fabef5e) to head (9ddc6d4).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
packages/gcloud-mcp/src/windows_gcloud_utils.ts 92.90% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #294      +/-   ##
==========================================
+ Coverage   93.64%   94.25%   +0.61%     
==========================================
  Files          46       51       +5     
  Lines        3225     3987     +762     
  Branches      426      413      -13     
==========================================
+ Hits         3020     3758     +738     
- Misses        205      229      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jackxu9946 Jackxu9946 changed the title FEAT: Support Windows OS for gcloud-mcp feat: Support Windows OS for gcloud-mcp Nov 19, 2025
@Jackxu9946 Jackxu9946 changed the title feat: Support Windows OS for gcloud-mcp feat: windows compatibility for gcloud mcp Nov 19, 2025
Copy link
Member

@burkedavison burkedavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please introduce the gcloud integration test shown in this PR: #284

As part of the integration test, please make sure that the test cases exercise both zero, one, and two python arguments.

Ex: -v -S

@Jackxu9946 Jackxu9946 force-pushed the user/xujack/fixWindowsPlatform branch from a8eef43 to 4b128f8 Compare November 19, 2025 18:23
Copy link
Member

@burkedavison burkedavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offline discussion.

@burkedavison burkedavison added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP server fails with "spawn gcloud ENOENT" error

2 participants