-
Notifications
You must be signed in to change notification settings - Fork 50
feat: windows compatibility for gcloud mcp #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
==========================================
+ Coverage 93.64% 94.25% +0.61%
==========================================
Files 46 51 +5
Lines 3225 3987 +762
Branches 426 413 -13
==========================================
+ Hits 3020 3758 +738
- Misses 205 229 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
burkedavison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please introduce the gcloud integration test shown in this PR: #284
As part of the integration test, please make sure that the test cases exercise both zero, one, and two python arguments.
Ex: -v -S
a8eef43 to
4b128f8
Compare
…oogleapis/gcloud-mcp into user/xujack/fixWindowsPlatform
burkedavison
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Offline discussion.
Added windows support for gcloud-mcp.
Gcloud-mcp will automatically detect which OS it is being ran in and automatically choose the correct gcloud invocation command for the platform
Fixes #275