-
Notifications
You must be signed in to change notification settings - Fork 1k
chore(deps): update module github.com/redis/go-redis/v9 to v9.17.2 #1994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(deps): update module github.com/redis/go-redis/v9 to v9.17.2 #1994
Conversation
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates github.com/redis/go-redis/v9 from v9.16.0 to v9.17.0. This is a minor update that includes new features, bug fixes, and performance improvements. I've reviewed the usage of go-redis in the codebase, and the update appears safe as there is no reliance on specific error strings that might have changed. However, this update introduces typed errors, which presents an opportunity for improving the code. I've added a comment on go.mod with a suggestion for a follow-up improvement to leverage the new typed error handling, which will enhance the Redis tool's usability and robustness.
go.mod
Outdated
| github.com/nakagami/firebirdsql v0.9.15 | ||
| github.com/neo4j/neo4j-go-driver/v5 v5.28.4 | ||
| github.com/redis/go-redis/v9 v9.16.0 | ||
| github.com/redis/go-redis/v9 v9.17.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This update to go-redis/v9 introduces typed errors, which is a great improvement for error handling. The current implementation in internal/tools/redis/redis.go handles all errors generically. For example, it treats redis.Nil (returned for non-existent keys) as a generic error, which can be misleading for the tool's users.
I recommend creating a follow-up task to refactor the error handling in internal/tools/redis/redis.go to specifically check for redis.Nil using errors.Is(err, redis.Nil) and handle it appropriately (e.g., by returning nil in the output array). This will make the tool's behavior more idiomatic and robust.
4a1a617 to
f599054
Compare
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
|
/gcbrun |
36a35eb to
307d3c5
Compare
|
/gcbrun |
This PR contains the following updates:
v9.16.0->v9.17.2Release Notes
redis/go-redis (github.com/redis/go-redis/v9)
v9.17.2: 9.17.2Compare Source
🐛 Bug Fixes
🧰 Maintenance
Contributors
We'd like to thank all the contributors who worked on this release!
@cyningsun and @ndyakov
v9.17.1: 9.17.1Compare Source
🐛 Bug Fixes
🧰 Maintenance
Contributors
We'd like to thank all the contributors who worked on this release!
@marcoferrer and @ndyakov
v9.17.0: 9.17.0Compare Source
🚀 Highlights
Redis 8.4 Support
Added support for Redis 8.4, including new commands and features (#3572)
Typed Errors
Introduced typed errors for better error handling using
errors.Asinstead of string checks. Errors can now be wrapped and set to commands in hooks without breaking library functionality (#3602)New Commands
IFEQ,IFNE,IFDEQ,IFDNE) (#3583, #3595)ACLGenPass,ACLUsers, andACLWhoAmI(#3576)SLOWLOG LENandSLOWLOG RESET(#3585)LATENCY LATESTandLATENCY RESET(#3584)Search & Vector Improvements
FT.HYBRIDcommand (#3573)VRANGEcommand for vector sets (#3543)Connection Pool Improvements
Metrics & Observability
✨ New Features
🐛 Bug Fixes
joinErrorsto prevent panic (#3577) by @manisharma⚡ Performance
🧪 Testing & Infrastructure
👥 Contributors
We'd like to thank all the contributors who worked on this release!
@12ya, @ajax16384, @cxljs, @cyningsun, @destinyoooo, @dragneelfps, @htemelski-redis, @manisharma, @ndyakov, @ofekshenawa, @pvragov
Full Changelog: redis/go-redis@v9.16.0...v9.17.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.