feat(tools/postgres): add list_pg_settings, list_database_stats tools for postgres #2030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srividyareddy786
force-pushed
the
observabilitytools
branch
from
3624808 to
74d0a8b
Compare
srividyareddy786
force-pushed
the
observabilitytools
branch
2 times, most recently
from
97ffcf5 to
e371d68
Compare
srividyareddy786
force-pushed
the
observabilitytools
branch
2 times, most recently
from
447e3ea to
3d12042
Compare
isaurabhuttam
approved these changes
Dec 2, 2025
averikitsch
added
the
release candidate
averikitsch
reviewed
Dec 3, 2025
averikitsch
reviewed
Dec 3, 2025
| func (t Tool) Invoke(ctx context.Context, resourceMgr tools.SourceProvider, params parameters.ParamValues, accessToken tools.AccessToken) (any, error) { | ||
| sliceParams := params.AsSlice() | ||
|
|
||
| results, err := t.pool.Query(ctx, ListDatabaseStats, sliceParams...) |
Contributor
There was a problem hiding this comment.
Do you want to log or throw an error if order by is not the right enum?
Contributor
Author
There was a problem hiding this comment.
Done. Updated the code.
Contributor
There was a problem hiding this comment.
The change does not validate "size" or "commit" enums for order by.
Contributor
There was a problem hiding this comment.
I have approved but we may wan to improve this tool by ensuring the input from LLM will be inserted into the SQL
Contributor
|
/gcbrun |
averikitsch
added
tests: run
averikitsch
added
docs: deploy-preview
Contributor
srividyareddy786
force-pushed
the
observabilitytools
branch
from
9291fbc to
63f6650
Compare
averikitsch
approved these changes
Dec 4, 2025
srividyareddy786
force-pushed
the
observabilitytools
branch
from
63f6650 to
cc2a454
Compare
…ublication-tables tool (googleapis#1919) Adds a postgresql custom list_publication_tables tool, that returns the details of publication tables present in database. Test Output: <img width="845" height="239" alt="Screenshot 2025-11-11 at 12 50 59 AM" src="https://github.com/user-attachments/assets/b7606e44-c5f6-4fc7-865e-7efadd112eff" /> <img width="1529" height="648" alt="Screenshot 2025-11-11 at 1 15 18 AM" src="https://github.com/user-attachments/assets/6192b772-f0bc-4fb4-8032-ca487434d77c" /> > Should include a concise description of the changes (bug or feature), it's > impact, along with a summary of the solution > Thank you for opening a Pull Request! Before submitting your PR, there are a > few things you can do to make sure it goes smoothly: - [x] Make sure you reviewed [CONTRIBUTING.md](https://github.com/googleapis/genai-toolbox/blob/main/CONTRIBUTING.md) - [x] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/genai-toolbox/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [x] Ensure the tests and linter pass - [x] Code coverage does not decrease (if any source code was changed) - [x] Appropriate docs were updated (if necessary) - [x] Make sure to add `!` if this involve a breaking change 🛠️ Fixes googleapis#1738 Co-authored-by: Averi Kitsch <[email protected]> Co-authored-by: Wenxin Du <[email protected]>
srividyareddy786
force-pushed
the
observabilitytools
branch
from
cc2a454 to
1bbb657
Compare
Contributor
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the following tools for Postgres:
(1) list_pg_settings: List configuration parameters for the PostgreSQL server.
(2) list_database_stats: Lists the key performance and activity statistics for each database in the postgreSQL
server.
list_pg_settings:
list_database_stats:
PR Checklist
CONTRIBUTING.md
bug/issue
before writing your code! That way we can discuss the change, evaluate
designs, and agree on the general idea
!if this involve a breaking change🛠️ Fixes #<1738>