This repository was archived by the owner on Aug 26, 2021. It is now read-only.
Fix incompatibility with latest react-router-dom #891
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfz
changed the title
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AUlinkList component is not compatible with the latest react-router-dom at the moment because react-router-dom uses React.forwardRef to create their Link component. The returned component from React.forwardRef tests false with
typeof ... === 'function', solinkdoesn't get passed to thetoprop.As far as I understand, AUlinkList can only use either "a" or
Link, so it can simply setlinktotowhen LinkComponent is not "a".Alternatively it can check whether LinkComponent is either Object or function, but I don't think it's necessary given how AUlinkList is used.