Skip to content

Merge of maven and gradle js docs #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fniephaus merged 1 commit into from
Jul 22, 2025
Merged

Merge of maven and gradle js docs #45

fniephaus merged 1 commit into from
Jul 22, 2025

Conversation

@ban-mi
Copy link
Member

@ban-mi ban-mi commented Jul 17, 2025 •
edited
Loading

Changed:

  • The file structure - merged maven and gradle for js
  • Added a brief leading line before some of the code blocks to improve clarity
  • GitHub workflow files

@ban-mi ban-mi requested review from fniephaus and olyagpl July 17, 2025 11:25
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 17, 2025
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
olyagpl
olyagpl reviewed Jul 17, 2025
View reviewed changes
Copy link
Member

@olyagpl olyagpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of merging demos instead of maintaining two separate READMEs!

@olyagpl
Copy link
Member

olyagpl commented Jul 17, 2025

You also need to adjust GitHub workflow files (adjust the paths to the demo folder):
https://github.com/graalvm/graal-languages-demos/blob/main/.github/workflows/graaljs-maven-webpack-guide.yml
https://github.com/graalvm/graal-languages-demos/blob/main/.github/workflows/graaljs-maven-webpack-guide.yml

@ban-mi ban-mi force-pushed the bm/merge-gradle-maven branch 3 times, most recently from 280bff5 to 29131bd Compare July 17, 2025 15:52
olyagpl
olyagpl previously approved these changes Jul 18, 2025
View reviewed changes
ban-mi
ban-mi commented Jul 18, 2025
View reviewed changes
@ban-mi ban-mi force-pushed the bm/merge-gradle-maven branch from 8616160 to 51011df Compare July 22, 2025 11:55
@ban-mi ban-mi changed the title Initial merge of maven and gradle js docs Merge of maven and gradle js docs Jul 22, 2025
fniephaus
fniephaus approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@fniephaus fniephaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for merging the two guides!

@fniephaus fniephaus merged commit 5176760 into main Jul 22, 2025
3 checks passed
@fniephaus fniephaus deleted the bm/merge-gradle-maven branch July 22, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fniephaus fniephaus fniephaus approved these changes

@olyagpl olyagpl olyagpl approved these changes

Assignees

@ban-mi ban-mi

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ban-mi @olyagpl @fniephaus