Skip to content

fix track_constraints support #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix track_constraints support #65

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28f9914
fix track_constraints support
bingochaos Feb 24, 2025
ea6839c
Merge branch 'freddyaboulton:main' into audio-track-constraints
bingochaos Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions frontend/shared/stream_utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,31 +8,39 @@ export function handle_error(error: string): void {

export function set_local_stream(
local_stream: MediaStream | null,
video_source: HTMLVideoElement,
video_source: HTMLVideoElement
): void {
video_source.srcObject = local_stream;
video_source.muted = true;
video_source.play();
}

export async function get_video_stream(
include_audio: boolean,
include_audio: boolean | { deviceId: { exact: string } },
video_source: HTMLVideoElement,
device_id?: string,
track_constraints?: MediaTrackConstraints,
track_constraints?:
| MediaTrackConstraints
| { video: MediaTrackConstraints; audio: MediaTrackConstraints }
): Promise<MediaStream> {
const fallback_constraints = track_constraints || {
width: { ideal: 500 },
height: { ideal: 500 },
};
const video_fallback_constraints = (track_constraints as any)?.video ||
track_constraints || {
width: { ideal: 500 },
height: { ideal: 500 },
};
const audio_fallback_constraints = (track_constraints as any)?.audio ||
track_constraints;

const constraints = {
video: device_id
? { deviceId: { exact: device_id }, ...fallback_constraints }
: fallback_constraints,
audio: include_audio,
? { deviceId: { exact: device_id }, ...video_fallback_constraints }
: video_fallback_constraints,
audio: include_audio
? typeof include_audio === "object"
? { ...include_audio, ...audio_fallback_constraints }
: audio_fallback_constraints
: false,
};

return navigator.mediaDevices
.getUserMedia(constraints)
.then((local_stream: MediaStream) => {
Expand All @@ -43,10 +51,10 @@ export async function get_video_stream(

export function set_available_devices(
devices: MediaDeviceInfo[],
kind: "videoinput" | "audioinput" = "videoinput",
kind: "videoinput" | "audioinput" = "videoinput"
): MediaDeviceInfo[] {
const cameras = devices.filter(
(device: MediaDeviceInfo) => device.kind === kind,
(device: MediaDeviceInfo) => device.kind === kind
);

return cameras;
Expand Down