-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Cc fixes 6.0 #12416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Cc fixes 6.0 #12416
Conversation
* Remove crop_size parameter from ImageEditor __init__ function and docstring description * Remove conversion code and deprecation warning message * Fix docstring typo * Remove deprecated ImageEditor crop_size references from demo files * Remove crop_size parameters and variable assignments in super().__init__() calls for Sketchpad, Paint, and ImageMask classes that inherit from ImageEditor * Regenerated notebook files --------- Co-authored-by: pngwn <[email protected]>
* First draft * Fix tests * add changeset * format * Fix reload test * Fix chatbot unit tests * lint * lint2 * Python unit tests * Fix code * Fix notebook --------- Co-authored-by: gradio-pr-bot <[email protected]>
* fix: enable padding by default in Markdown component * add changeset * add changeset * Fix: set the padding to false for both HTML and Markup * Enable padding by default in HTML component * fix: Fixed failing unit test and a docstring --------- Co-authored-by: Abubakar Abid <[email protected]> Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Freddy Boulton <[email protected]>
* Set allow tags to true by default. * add changeset --------- Co-authored-by: gradio-pr-bot <[email protected]>
* Fix * Fix * Fix * lint * Fix
* Audio * Fix * Video * Fix * Docs * Fix tests * Fix * Fix * Fix typos
… `show_xxxxxxx_button` parameters (#12042) * change buttons * docstring * changes * changes * notebooks * changes * changes * fix tests * fix lint * changes * changes * fix json test * story * format
* Rename hf_token -> token * remove * Do client * remaining files * Guides * Fix * empty
* subtitles * add video subtitles and allow json subs * add changeset * format * notebook * remove * remove test files * notebook fix * merge fix * remove unused prop * type fix * test fix * test fixes * format --------- Co-authored-by: gradio-pr-bot <[email protected]>
* remove ws * Fix: * remove * remove ws * Format
* Fix * Fix
* fix * add changeset --------- Co-authored-by: gradio-pr-bot <[email protected]>
* Fix toast full width issue * add changeset * Fix * Fix * fix broken media query * multimodal textbox recorder * fix custom components (#12397) * fix * clean * add changeset * add changeset --------- Co-authored-by: gradio-pr-bot <[email protected]> * add changeset --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: hannahblair <[email protected]> Co-authored-by: pngwn <[email protected]>
* fix * fix * fix
* changes * changes * changes * add changeset * Update guides/10_mcp/01_building-mcp-server-with-gradio.md --------- Co-authored-by: gradio-pr-bot <[email protected]>
* changes * add changeset * changes * changes * tweak demo * changes * changes * changes * changes * changes * changes * changes * Update gradio/blocks.py Co-authored-by: Abubakar Abid <[email protected]> * Update gradio/blocks.py Co-authored-by: Abubakar Abid <[email protected]> * Update gradio/routes.py Co-authored-by: Abubakar Abid <[email protected]> * changes --------- Co-authored-by: Ali Abid <[email protected]> Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Abubakar Abid <[email protected]> Co-authored-by: Ali Abid <[email protected]>
* multimodal textbox recorder * add changeset * improve styling * revert css tweaks * make icon styling consistent * file fix * handle errors * mobile input width --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Freddy Boulton <[email protected]>
* chanbges * add changeset * changes * Fix CI * Fix unit tests --------- Co-authored-by: Ali Abid <[email protected]> Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Freddy Boulton <[email protected]>
…#12412) * fix: Using root instead of mcp_server_url for file upload config docs * add changeset --------- Co-authored-by: Freddy Boulton <[email protected]> Co-authored-by: gradio-pr-bot <[email protected]>
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/446b51ab6e99ba1f892e7df38f91ef1a5f3a35fb/gradio-5.49.1-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@446b51ab6e99ba1f892e7df38f91ef1a5f3a35fb#subdirectory=client/python"Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/446b51ab6e99ba1f892e7df38f91ef1a5f3a35fb/gradio-client-2.0.0-dev.2.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
|
|
The vite configs are a bit cursed tbh but i don't have the energy to fix them. We can clean them up post-release. |
| this.update_state_cb = update_state_cb; | ||
| this.get_state_cb = get_state_cb; | ||
| this.rerender_cb = rerender_cb; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added these back.
| const current_state = await this.get_state_cb?.(id); | ||
| if (!current_state) return () => {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was getting an error here. I think the effect runs immediately before we have properly initialised, so this just catches that scenario without an error.
| this.#config = { | ||
| ...config, | ||
| api_url: new URL(config.api_prefix, config.root).toString() | ||
| }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a new 'url' to the local config which is just the root + api_prefix for use when fetching custom components.
| this.#config.api_url, | ||
| { ...this.#config } | ||
| ); | ||
|
|
||
| const type = | ||
| type_map[component.type as keyof typeof type_map] || component.type; | ||
|
|
||
| const node = { | ||
| id: opts.id, | ||
| type: type, | ||
| props: processed_props, | ||
| children: [], | ||
| show_progress_on: null, | ||
| component_class_id: component.component_class_id || component.type, | ||
| component: | ||
| processed_props.shared_props.visible !== false | ||
| ? get_component( | ||
| component.type, | ||
| component.component_class_id, | ||
| this.#config.root || "" | ||
| this.#config.api_url || "" | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything else in this file was just an unused root argument that I removed (which simplified things nicely).
* Fix code * add changeset * notebook --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Abubakar Abid <[email protected]>
* Fix browser component tests * add changeset * Fix reload mode tests * add changeset * Fix * Fix * Fix tabs * Fix * add changeset * Fix * Fix race condition * Fix * Skip troll tabs test * Skip tabs: * Fix --------- Co-authored-by: gradio-pr-bot <[email protected]>
* fix console error in dependency.ts * load vibe editor correctly * add changeset * switch to onmount * lint + fix --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Freddy Boulton <[email protected]>
* changes * add changeset * changes * changes * changes * add changeset * changes * changes * format * changes * changes * revert * revert * revert * add changeset * plc * revert * changes * changes" * changes * changes * fix * fix test --------- Co-authored-by: gradio-pr-bot <[email protected]> Co-authored-by: Freddy Boulton <[email protected]>
This PR:
I also fixed a few types, cleaned up some unused arguments, and fixed some small bugs I found.