refactor: get clients from TFprovider with xplane providerConfig #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suntala
reviewed
Oct 28, 2025
suntala
left a comment
suntala
left a comment
There was a problem hiding this comment.
It would be great if we could add some tests (for instance the conversion to providerConfig). This would serve as a form of documentation as well for those new to the repo.
| K6URL: stringValueOrNull(d, "k6_url"), | ||
| K6AccessToken: stringValueOrNull(d, "k6_access_token"), | ||
| StoreDashboardSha256: boolValueOrNull(d, "store_dashboard_sha256"), | ||
| //HTTPHeaders: headers, |
There was a problem hiding this comment.
Could we please add an explanation about if/when we want to include these?
Contributor
Author
There was a problem hiding this comment.
I've added a comment above of this function to explain where this comes from.
Contributor
Author
|
I see most of the code makes calls to Grafana or cycles through information from Crossplane, it feels like most unit tests would require extensive mocking with little logic left to actually test. Is it okay if we postpone testing work until we've proven this POC? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces logic to get the API clients via the TF provider. This reduces the need to copy all the API init logic. It does require some type casting but other than that it looks fairly straightforward.
The
clients.gofile has to jump through two hoops. First turning theproviderConfiginto amap[string]any, this logic is copy/pasta from the Crossplane provider. Second turning themap[string]anyinto the TFproviderConfig. It might be useful to refactor upstream so that this logic is available throughpkg/instead of ininternal/.