This image is used to build Go projects. It contains the Go compiler (from the official golang container) as well as additional tools that help with building projects.
First you need to confirm that the image is building and that the changes are present:
- update
Dockerfileand add all the changes you want to add to this base image. - run
make buildand make sure it passes. - run
make shelland test your changes are indeed present. - run
make testto make sure all components are working.
Once you confirmed the build passes and the changes are as expected do the following:
- create a commit with
Makefile,Dockerfileandlib/image-testchanges. - push the changes and create a new pull request.
After the PR gets reviewed you need to check all the different places where grafana-build-tools is used and update accordingly. Here git grep is your friend:
git grep grafana-build-toolswill list all places wheregrafana-build-toolsis used.git grep grafana-build-tools:$OLDVERSIONsame as before, but more restrictive.
Assuming sane versioning schemas for the tools this container uses, the following guidelines apply:
- If a tool updates its major number, this repo should update its major number
- If a tool updates its minor number, this repo should update its minor number
- If a tool updates its patch number, this repo should update its patch number
- If a tool is removed, this repo should update its major number
- If a feature for the logic within this repo is implemented, this repo should update its minor number
- If a fix for the logic within this repo is implemented, this repo should update its patch number