Skip to content

Feature/crytpo pbkdf2 #5380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Feature/crytpo pbkdf2 #5380

wants to merge 13 commits into from
+809 −91

Conversation

@rahulmedicharla
Copy link

@rahulmedicharla rahulmedicharla commented Nov 7, 2025 •
edited
Loading

What

This PR implements the PBKDF2 support in the webcrypto module following the WebCrypto Api specification.

Why?

Having support of the PBKDF2 makes our implementation compliant with web crypto API

Checklist

  • I have performed a self-review of my code.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added tests for my changes.
  • I have run linter and tests locally (make check) and all pass.

Checklist: Documentation (only for k6 maintainers and if relevant)

Please do not merge this PR until the following items are filled out.

  • I have added the correct milestone and labels to the PR.
  • I have updated the release notes: link
  • I have updated or added an issue to the k6-documentation: grafana/k6-docs#NUMBER if applicable
  • I have updated or added an issue to the TypeScript definitions: grafana/k6-DefinitelyTyped#NUMBER if applicable

Related PR(s)/Issue(s)

Closes #4267

rahulmedicharla and others added 4 commits November 7, 2025 07:37
@rahulmedicharla
working pbkdf2 deriveKey, deriveBits, and importKey implementation
3ef67de
@inancgumus
Fix execution context navigates away bug
a566c36 
This PR made this race condition apparent, so instead of adding another
PR to fix it, I've added a small commit here to fix the issue.
@mstoykov
browser: Fix browsers not being stopped in tests due to EndIteration …
b36f8c9 
…not being called
@rahulmedicharla
added tests for pbkdf2, fixed ecdh for tests, added examples for deri…
f40aa49 
…veKey & deriveBits in pbkdf2
@rahulmedicharla rahulmedicharla requested a review from a team as a code owner November 7, 2025 16:54
@rahulmedicharla rahulmedicharla requested review from AgnesToulet and mstoykov and removed request for a team November 7, 2025 16:54
@CLAassistant
Copy link

CLAassistant commented Nov 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 7, 2025 17:21 — with GitHub Actions Inactive
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 7, 2025 17:24 — with GitHub Actions Inactive
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 7, 2025 23:10 — with GitHub Actions Inactive
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 7, 2025 23:11 — with GitHub Actions Inactive
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 8, 2025 08:37 — with GitHub Actions Inactive
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 8, 2025 08:39 — with GitHub Actions Inactive
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 13, 2025 11:45 — with GitHub Actions Inactive
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 13, 2025 11:47 — with GitHub Actions Inactive
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 15, 2025 15:07 — with GitHub Actions Inactive
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 15, 2025 15:09 — with GitHub Actions Inactive
@mstoykov mstoykov added this to the v1.5.0 milestone Nov 17, 2025
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 18, 2025 12:45 — with GitHub Actions Inactive
@rahulmedicharla rahulmedicharla temporarily deployed to azure-trusted-signing November 18, 2025 12:48 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mstoykov mstoykov Awaiting requested review from mstoykov mstoykov is a code owner automatically assigned from grafana/k6-core

@AgnesToulet AgnesToulet Awaiting requested review from AgnesToulet AgnesToulet is a code owner automatically assigned from grafana/k6-core

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.5.0

Development

Successfully merging this pull request may close these issues.

Implement PBKDF2 across supported API

4 participants

@rahulmedicharla @CLAassistant @mstoykov @inancgumus