Skip to content

Conversation

@faridnsh
Copy link

@faridnsh faridnsh commented Oct 29, 2025

More context on #75. Closes #75

Basically adds orderBy, first and last parameters to groupedAggregates. orderBy accepts any possible field aggregations. Note that I still don't have a very good understanding of the project, this PR is party AI generated and partly from copy pasting various concepts around, would appreciate deep review from someone who understands the code better to see if there can better ways.

Performance impact

Slight performance impact in startup time due to added(18 entries per numerical fields in AggregatesOrderBy enum)

Security impact

Shouldn't be.

Checklist

  • My code matches the project's code style and yarn lint:fix passes. - I'm working on estlint to run properly
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists). - File doesn't exist
  • If this is a breaking change I've explained why. - not a breaking change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant