Decapitalize Custom, Scalar and String #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glen-84
suggested changes
Dec 1, 2025
Contributor
Author
|
Thanks for the review @glen-84, this all makes sense to me 👍 |
Contributor
Author
|
BTW, Title Case is mentioned in the spec style guide there: https://github.com/graphql/graphql-spec/blob/main/STYLE_GUIDE.md#title-case |
glen-84
approved these changes
Dec 1, 2025
Contributor
Author
|
@andimarek ok to merge this one? |
Contributor
Author
|
Since this is an easy PR to revert, I'll go ahead an merge it. @andimarek let me know if you have any objection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up from https://github.com/graphql/graphql-scalars/pull/31/files, Custom and Scalar are not capitalized in the spec. String is only capitalized when it is the name of the built-in
Stringscalar. But not in the context of a "string" value.