adds traces for dataloaders #33
Conversation
| The span SHOULD be a child of the span that initiated the batch loading, | ||
| which is typically a resolver execution span. |
There was a problem hiding this comment.
You probably already discussed this during the meeting, but I'm not sure to understand this part.
What does "initiated the batch loading" ? Is it the last or the first resolver that called this DataLoader ?
And this means that other resolvers spans will not have anything to do with this span. Should we specify that the DataLoader span should be linked to every resolver spans involved in the batch ? Because a common need is to being able to track down which resolver triggered a DataLoader batch.
| The span SHOULD be a child of the span that initiated the batch loading, | ||
| which is typically a resolver execution span. | ||
| attributes: |
There was a problem hiding this comment.
I think that would be useful to also know the number of cache miss/hit isn't it ?
|
@benjie Fair point. They can technically be used outside of GraphQL - yet they rarely are. At least I've only seen usecases outside of the GraphQL execution by people working with a GraphQL server somewhere else in the application. I grouped them under the |
No description provided.