-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Cherry-pick #8536 to v1.77.x #8691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…pc#8536) Part two for grpc/proposal#492 (A97), following grpc#8431 . What this PR does is: - update `internal/xds/bootstrap` with support for loading multiple PerRPCCallCredentials specifed in a new `call_creds` field in the boostrap file as per A97 - adjust `xds/internal/xdsclient/clientimpl.go`to use the call credentials when constructing the client - update `xds/bootstrap` to register the `jwtcreds` call credentials and make them available if `GRPC_EXPERIMENTAL_XDS_BOOTSTRAP_CALL_CREDS` is enabled Relates to istio/istio#53532 RELEASE NOTES: - xds: add support for loading a JWT from file and use it as Call Credentials (A97). To enable this feature, set the environment variable `GRPC_EXPERIMENTAL_XDS_BOOTSTRAP_CALL_CREDS` to `true` (case insensitive).
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.77.x #8691 +/- ##
===========================================
- Coverage 83.34% 83.30% -0.05%
===========================================
Files 417 418 +1
Lines 32296 32347 +51
===========================================
+ Hits 26918 26946 +28
- Misses 4006 4025 +19
- Partials 1372 1376 +4
🚀 New features to boost your workflow:
|
|
Do we really need this to be cherrypicked? Is anyone wanting this feature in the upcoming release? Thanks. |
This change allows Istio users to depend on a tagged gRPC release (instead of a commit hash) for resolving issue istio/istio#53532. We will get a week of internal testing to catch regressions before the 1.77 release, and I don't see any significant harm in including it. |
Original PR: #8536
RELEASE NOTES:
GRPC_EXPERIMENTAL_XDS_BOOTSTRAP_CALL_CREDStotrue(case insensitive).