Remove the looping video CORS feature switch and 0% test #14806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
abeddow91
added
maintenance
abeddow91
added
fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨Do not merge until Monday 10th November 🚨
What does this change?
Remove the looping video CORS feature switch and 0% test and release it 100% into PROD. Looping videos will now always have crossOrigin="anonymous" applied
We can also safely remove the
?cors=enabledquery param cache buster from the sources urls as this will have been active for 4 days by the time of deployment on Monday 10th November. This is because loops are short lived on fronts and do not typically return to fronts after several days meaning, by Monday, any cached assets should already carry the correct CORS headers.Why?
We have successfully released CORS via the feature switch into production without any issues. As such, we can remove the feature switch and 0% test as these are no longer required.