-
Notifications
You must be signed in to change notification settings - Fork 73
Delete Wise fee expense when report transitions to draft #12017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: YodaLightsabr <[email protected]>
Co-authored-by: YodaLightsabr <[email protected]>
Co-authored-by: YodaLightsabr <[email protected]>
Co-authored-by: YodaLightsabr <[email protected]>
Co-authored-by: YodaLightsabr <[email protected]>
Copilot
AI
changed the title
[WIP] Delete Wise fee expense on report unapproval
Delete Wise fee expense when report transitions to draft
Nov 4, 2025
Copilot finished work on behalf of
YodaLightsabr
November 4, 2025 01:13
garyhtou
reviewed
Nov 4, 2025
YodaLightsabr
requested changes
Nov 4, 2025
YodaLightsabr
approved these changes
Nov 4, 2025
YodaLightsabr
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a reimbursement report with Wise transfer fees is unapproved, the fee expense must be deleted since it's no longer applicable.
Changes
mark_drafttransition to allowreimbursement_approved → draftwith callback to delete Wise fee expensesWISE_TRANSFER_FEE_MEMOto ensure consistency between fee creation and deletionImplementation
The callback specifically targets expenses by both type and memo to avoid deleting unrelated fees.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.