-
Notifications
You must be signed in to change notification settings - Fork 137
Fix an issue where overwriting a non-computed cell caused the Value of the formula cell is not computed error
#1569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sequba
wants to merge
9
commits into
develop
Choose a base branch
from
feature/issue-1194
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance comparison of head (1d84e45) vs base (48647e5) |
Value of the formula cell is not computedValue of the formula cell is not computed error
Contributor
Author
|
After merging it should be tested by our QA team |
Value of the formula cell is not computed errorValue of the formula cell is not computed error
Value of the formula cell is not computed errorValue of the formula cell is not computed error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1569 +/- ##
========================================
Coverage 97.22% 97.22%
========================================
Files 169 169
Lines 14536 14547 +11
Branches 3174 3178 +4
========================================
+ Hits 14133 14144 +11
Misses 396 396
Partials 7 7
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Analysis:
In some cases, a non-computed cell (formula cell or array cell) throws
Value of the formula cell is not computederror when being overwritten by other value. It shouldn't happen. We don't need to compute a value that is about to be gone.Fix:
Checking for non-computed cells before overwriting.
How did you test your changes?
Types of changes
Related issues:
Value of the formula cell is not computedafter call toaddNamedExpressionandupdateConfig#1194Checklist: