Skip to content

Conversation

@sequba
Copy link
Contributor

@sequba sequba commented Oct 31, 2025

Context

Analysis:
In some cases, a non-computed cell (formula cell or array cell) throws Value of the formula cell is not computed error when being overwritten by other value. It shouldn't happen. We don't need to compute a value that is about to be gone.

Fix:
Checking for non-computed cells before overwriting.

How did you test your changes?

  • added unit tests that reproduce the issue
  • all unit tests pass
  • approved by @Wojciech-Swiderski

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

  1. Fixes Error Value of the formula cell is not computed after call to addNamedExpression and updateConfig #1194

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Performance comparison of head (1d84e45) vs base (48647e5)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A |  485.8 | 493.67 | +1.62%
                                      Sheet B | 159.33 | 159.56 | +0.14%
                                      Sheet T |  141.1 | 139.97 | -0.80%
                                Column ranges | 488.39 | 488.27 | -0.02%
Sheet A:  change value, add/remove row/column |  12.97 |  12.98 | +0.08%
 Sheet B: change value, add/remove row/column | 122.83 | 122.89 | +0.05%
                   Column ranges - add column | 131.21 | 133.79 | +1.97%
                Column ranges - without batch | 396.95 | 409.53 | +3.17%
                        Column ranges - batch | 110.44 | 112.42 | +1.79%

@sequba sequba changed the title Fix Value of the formula cell is not computed Fix Value of the formula cell is not computed error Oct 31, 2025
@sequba
Copy link
Contributor Author

sequba commented Oct 31, 2025

After merging it should be tested by our QA team

@sequba sequba marked this pull request as ready for review October 31, 2025 12:16
@sequba sequba requested a review from qunabu October 31, 2025 12:16
@sequba sequba changed the title Fix Value of the formula cell is not computed error Fix error when overwriting a non-computed cell caused the Value of the formula cell is not computed error Oct 31, 2025
@sequba sequba changed the title Fix error when overwriting a non-computed cell caused the Value of the formula cell is not computed error Fix an issue where overwriting a non-computed cell caused the Value of the formula cell is not computed error Oct 31, 2025
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.22%. Comparing base (48647e5) to head (1d84e45).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1569   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14536    14547   +11     
  Branches      3174     3178    +4     
========================================
+ Hits         14133    14144   +11     
  Misses         396      396           
  Partials         7        7           
Files with missing lines Coverage Δ
src/Operations.ts 98.92% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants