fix: Save the code if there's an output too. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Yusuf, it's Alper. Good to see you here! It's been a while since you told me about this code, and I'm glad to have the opportunity to get my hands on it finally.
This commit addresses the issue where the "show" command in the TermiC script was not displaying the entire code. The issue was that the script would only "save" the code for "show" to display if there was no output. This behaviour also affects the core functionality, because the script appends the new prompts into the persistent file instead of the temporary one, which will result in not including the previous outputting codes even if more lines are added. I am not sure if this is an intended behaviour, with the consideration that printing could be used for debugging only and maybe you wouldn't want them in your final code in some cases.
Changed it so that it'll save if there's an output too.
This PR fixes #14.