Skip to content

Conversation

@berimbolo13
Copy link

@berimbolo13 berimbolo13 commented Dec 8, 2025

Closes #44925

Removes hardcoded delays and continuous target occurrence checks before polling instance state during creation, stop, and deletion operations. The provider will now begin polling immediately with a 10-second interval.

This significantly reduces wait times for:

  • Fast AWS provisioning scenarios
  • Local testing with LocalStack (lightweight AWS emulator)

Background:
These delays were introduced in 2014 without explanation (originally committed to terraform repo without a PR). When Blue/Green deployments were introduced, delays were increased further with no documented rationale.

The ContinuousTargetOccurence parameter was added in commit 4e1733e (Nov 20, 2024) with only "Add ContinuousTargetOccurence" as the commit message, providing no context for why multiple consecutive checks are needed.

This change removes both the initial delays and the continuous target checks, allowing the provider to begin polling immediately whilst keeping the 10-second poll interval to prevent RDS API rate limiting.

Related:

@berimbolo13 berimbolo13 requested a review from a team as a code owner December 8, 2025 08:27
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR. labels Dec 8, 2025
@justinretzolk justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. localstack LocalStack-specific issues and PRs. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Requests to existing resources that expand the functionality or scope. localstack LocalStack-specific issues and PRs. service/rds Issues and PRs that pertain to the rds service. size/XS Managed by automation to categorize the size of a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slow RDS instance creation

2 participants