rds: Remove delays and ContinuousTargetOccurence from DB instance operations #45480
+9
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #44925
Removes hardcoded delays and continuous target occurrence checks before polling instance state during creation, stop, and deletion operations. The provider will now begin polling immediately with a 10-second interval.
This significantly reduces wait times for:
Background:
These delays were introduced in 2014 without explanation (originally committed to terraform repo without a PR). When Blue/Green deployments were introduced, delays were increased further with no documented rationale.
The
ContinuousTargetOccurenceparameter was added in commit 4e1733e (Nov 20, 2024) with only "Add ContinuousTargetOccurence" as the commit message, providing no context for why multiple consecutive checks are needed.This change removes both the initial delays and the continuous target checks, allowing the provider to begin polling immediately whilst keeping the 10-second poll interval to prevent RDS API rate limiting.
Related: