data.aws_route53_resolver_rule: Add target_ips attribute #45492
+95
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
Contributor
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
github-actions
bot
added
needs-triage
tellnes
force-pushed
the
f-route53-resolver-rule-data-source-target-ips
branch
from
13d8eca to
887a2a5
Compare
justinretzolk
added
enhancement
Adds the `target_ips` attribute to the `aws_route53_resolver_rule` data source to expose the list of target IP addresses configured for FORWARD rules. This includes IPv4 (`ip`), IPv6 (`ipv6`), port, and protocol information for each target.
tellnes
force-pushed
the
f-route53-resolver-rule-data-source-target-ips
branch
from
887a2a5 to
a86fe80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
target_ipsattribute to theaws_route53_resolver_ruledata source.Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
No changes to security controls.
Description
Exposes the target IP addresses configured for Route53 Resolver FORWARD rules. Each target includes
ip,ipv6,port, andprotocolfields.This data is available from the AWS API and is already exposed in the corresponding resource, so this change brings the data source to feature parity for read operations.
The implementation reuses the existing
flattenRuleTargetIPsfunction from the resource to maintain consistency.Note: The
server_name_indicationfield is not included in this PR as it is being added separately in #40127 to avoid conflicts and ensure proper implementation across both the resource and data source.References
server_name_indication: r/aws_route53_resolver_rule enhancement: new argumentserver_name_indicationtotarget_ipblock #40127Output from Acceptance Testing