Skip to content

Conversation

@ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Dec 9, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Adds terraform query support for aws_kms_key.

Relations

Closes #45508.
Relates #44129.

Output from Acceptance Testing

% make testacc TESTARGS='-run=TestAccKMSKey_List_basic' PKG=kms
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-aws_kms_key-list 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/kms/... -v -count 1 -parallel 20  -run=TestAccKMSKey_List_basic -timeout 360m -vet=off
2025/12/10 11:47:53 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/10 11:47:53 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccKMSKey_List_basic
=== PAUSE TestAccKMSKey_List_basic
=== CONT  TestAccKMSKey_List_basic
--- PASS: TestAccKMSKey_List_basic (22.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/kms	27.894s

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added service/kms Issues and PRs that pertain to the kms service. generators Relates to code generators. size/M Managed by automation to categorize the size of a PR. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Dec 9, 2025
@ewbankkit ewbankkit added the new-list-resource Introduces list resource support. label Dec 9, 2025
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Dec 9, 2025
@ewbankkit ewbankkit marked this pull request as ready for review December 10, 2025 16:50
@ewbankkit ewbankkit requested a review from a team as a code owner December 10, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. new-list-resource Introduces list resource support. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. service/kms Issues and PRs that pertain to the kms service. size/L Managed by automation to categorize the size of a PR. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

r/aws_kms_key: Add list support

1 participant