Skip to content

Conversation

@psantus
Copy link
Contributor

@psantus psantus commented Dec 10, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

None

Description

This PR introduces a new aws_dms_data_provider resource. This is the first step for managing new DMS migration projects

Relations

refs #38004

References

API Reference

Output from Acceptance Testing

% TF_ACC=1 go test -v -run=TestAccDMSDataProvider ./internal/service/dms -timeout 30m

2025/12/10 00:55:31 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccDMSDataProvider_basic
=== PAUSE TestAccDMSDataProvider_basic
=== RUN   TestAccDMSDataProvider_update
=== PAUSE TestAccDMSDataProvider_update
=== RUN   TestAccDMSDataProvider_disappears
=== PAUSE TestAccDMSDataProvider_disappears
=== CONT  TestAccDMSDataProvider_basic
=== CONT  TestAccDMSDataProvider_disappears
=== CONT  TestAccDMSDataProvider_update
--- PASS: TestAccDMSDataProvider_disappears (23.12s)
--- PASS: TestAccDMSDataProvider_basic (26.31s)
--- PASS: TestAccDMSDataProvider_update (38.73s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/dms        43.407s

Implements CreateDataProvider, DescribeDataProviders, ModifyDataProvider, and DeleteDataProvider APIs.

Supports PostgreSQL and MySQL data provider settings with proper handling of AWS SDK union types.

Includes:
- Resource implementation with CRUD operations
- Acceptance tests (basic, update, disappears)
- Documentation with examples
- Tags support
- Added IbmDb2LuwSettings, IbmDb2zOsSettings, SybaseAseSettings
- Added virtual flag support
- Used generic expand/flatten with reflection for all settings types
- Updated documentation with all settings types
- All tests passing
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/dms Issues and PRs that pertain to the dms service. size/XL Managed by automation to categorize the size of a PR. labels Dec 10, 2025
@psantus psantus marked this pull request as ready for review December 10, 2025 01:13
@psantus psantus requested a review from a team as a code owner December 10, 2025 01:13
@psantus
Copy link
Contributor Author

psantus commented Dec 10, 2025

@hashicorp/terraform-aws I commit to delivering all resources mentioned in #38004 if this one gets reviewed and merged. (other will depend on this one).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. needs-triage Waiting for first response or review from a maintainer. service/dms Issues and PRs that pertain to the dms service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant