F aws cloudfront trust store #45534
Open
F aws cloudfront trust store #45534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
Contributor
|
✅ Thank you for correcting the previously detected issues! The maintainers appreciate your efforts to make the review process as smooth as possible. |
github-actions
bot
added
needs-triage
ewbankkit
added
new-resource
github-actions
bot
added
the
prioritized
% make testacc TESTARGS='-run=TestAccCloudFrontTrustStore_' PKG=cloudfront ACCTEST_PARALLELISM=2 make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 HEAD 🌿... TF_ACC=1 go1.24.11 test ./internal/service/cloudfront/... -v -count 1 -parallel 2 -run=TestAccCloudFrontTrustStore_ -timeout 360m -vet=off 2025/12/11 14:39:59 Creating Terraform AWS Provider (SDKv2-style)... 2025/12/11 14:39:59 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccCloudFrontTrustStore_basic === PAUSE TestAccCloudFrontTrustStore_basic === RUN TestAccCloudFrontTrustStore_disappears === PAUSE TestAccCloudFrontTrustStore_disappears === RUN TestAccCloudFrontTrustStore_withS3ObjectVersion === PAUSE TestAccCloudFrontTrustStore_withS3ObjectVersion === RUN TestAccCloudFrontTrustStore_update === PAUSE TestAccCloudFrontTrustStore_update === CONT TestAccCloudFrontTrustStore_basic === CONT TestAccCloudFrontTrustStore_withS3ObjectVersion --- PASS: TestAccCloudFrontTrustStore_basic (21.68s) === CONT TestAccCloudFrontTrustStore_disappears --- PASS: TestAccCloudFrontTrustStore_withS3ObjectVersion (24.47s) === CONT TestAccCloudFrontTrustStore_update --- PASS: TestAccCloudFrontTrustStore_disappears (18.03s) --- PASS: TestAccCloudFrontTrustStore_update (37.12s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 67.423s
ewbankkit
previously approved these changes
Dec 11, 2025
Contributor
ewbankkit
left a comment
ewbankkit
left a comment
There was a problem hiding this comment.
LGTM 🚀.
% make testacc TESTARGS='-run=TestAccCloudFrontTrustStore_' PKG=cloudfront ACCTEST_PARALLELISM=2
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 HEAD 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/cloudfront/... -v -count 1 -parallel 2 -run=TestAccCloudFrontTrustStore_ -timeout 360m -vet=off
2025/12/11 15:02:09 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/11 15:02:09 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN TestAccCloudFrontTrustStore_basic
=== PAUSE TestAccCloudFrontTrustStore_basic
=== RUN TestAccCloudFrontTrustStore_disappears
=== PAUSE TestAccCloudFrontTrustStore_disappears
=== RUN TestAccCloudFrontTrustStore_withS3ObjectVersion
=== PAUSE TestAccCloudFrontTrustStore_withS3ObjectVersion
=== RUN TestAccCloudFrontTrustStore_update
=== PAUSE TestAccCloudFrontTrustStore_update
=== RUN TestAccCloudFrontTrustStore_tags
=== PAUSE TestAccCloudFrontTrustStore_tags
=== CONT TestAccCloudFrontTrustStore_basic
=== CONT TestAccCloudFrontTrustStore_update
--- PASS: TestAccCloudFrontTrustStore_basic (21.85s)
=== CONT TestAccCloudFrontTrustStore_tags
--- PASS: TestAccCloudFrontTrustStore_update (38.12s)
=== CONT TestAccCloudFrontTrustStore_withS3ObjectVersion
--- PASS: TestAccCloudFrontTrustStore_withS3ObjectVersion (24.05s)
=== CONT TestAccCloudFrontTrustStore_disappears
--- PASS: TestAccCloudFrontTrustStore_tags (47.15s)
--- PASS: TestAccCloudFrontTrustStore_disappears (18.78s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 86.263s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Added a new resource
aws_cloudfront_trust_storeRelations
Partially addresses #45249
References
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/cloudfront#Client.CreateTrustStore
https://pkg.go.dev/github.com/aws/aws-sdk-go-v2/service/cloudfront#Client.UpdateTrustStore
Output from Acceptance Testing