Skip to content

Conversation

@YakDriver
Copy link
Member

@YakDriver YakDriver commented Dec 10, 2025

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Relations

Closes #0000

References

Output from Acceptance Testing

% make testacc TESTS=TestAccXXX PKG=ec2

...

YakDriver and others added 24 commits December 9, 2025 09:40
- Regular mode: nil slice → null List/Set (correct behavior)
- Legacy mode: nil slice → empty List/Set (backwards compatible)
- Fixes TestFlattenSimpleListOfPrimitiveValues and TestFlattenSimpleSetOfPrimitiveValues
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.39.0 to 0.40.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.39.0...v0.40.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-version: 0.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/hashicorp/aws-sdk-go-base/v2](https://github.com/hashicorp/aws-sdk-go-base) from 2.0.0-beta.68 to 2.0.0-beta.69.
- [Release notes](https://github.com/hashicorp/aws-sdk-go-base/releases)
- [Changelog](https://github.com/hashicorp/aws-sdk-go-base/blob/main/CHANGELOG.md)
- [Commits](hashicorp/aws-sdk-go-base@v2.0.0-beta.68...v2.0.0-beta.69)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/aws-sdk-go-base/v2
  dependency-version: 2.0.0-beta.69
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.39.0 to 0.40.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](golang/tools@v0.39.0...v0.40.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-version: 0.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
---
updated-dependencies:
- dependency-name: github.com/hashicorp/aws-sdk-go-base/v2
  dependency-version: 2.0.0-beta.69
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-sdk-go-base
...

Signed-off-by: dependabot[bot] <[email protected]>
…com/aws/aws-sdk-go-v2/otelaws

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws
  dependency-version: 0.64.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-version: 0.40.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
- Add dual verification approach (normal + write-only paths)
- Add TestAccSecretsManagerSecretVersion_stringWriteOnly_stages
- Add helper functions: testAccCheckSecretVersionExistsWriteOnly,
  testAccCheckSecretVersionWriteOnlyValueEmpty,
  testAccCheckSecretVersionWriteOnlyStagesEqual
- Export findSecretVersionEntryByTwoPartKey for testing

Based on testing approach from PR #43579

Co-authored-by: Matt Thaber <[email protected]>
- Rename checkExists to findSecretVersionForExistence (more descriptive)
- Use early return pattern in Read function to avoid deep nesting
- Remove unnecessary nil check for versionEntry
- Consolidate duplicate error handling
- Set write-only attributes in single location
This document will be a user-facing record for why the `user_agent` argument is a list of strings in `provider_meta`.
Adds support for a new changelog entry type, `new-list-resource`.
@YakDriver YakDriver requested a review from a team as a code owner December 10, 2025 17:06
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/cloudfront Issues and PRs that pertain to the cloudfront service. labels Dec 10, 2025
@github-actions github-actions bot added provider Pertains to the provider itself, rather than any interaction with AWS. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. service/eks Issues and PRs that pertain to the eks service. linter Pertains to changes to or issues with the various linters. generators Relates to code generators. size/XL Managed by automation to categorize the size of a PR. labels Dec 10, 2025
@YakDriver YakDriver marked this pull request as draft December 10, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. linter Pertains to changes to or issues with the various linters. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. provider Pertains to the provider itself, rather than any interaction with AWS. service/cloudfront Issues and PRs that pertain to the cloudfront service. service/eks Issues and PRs that pertain to the eks service. service/secretsmanager Issues and PRs that pertain to the secretsmanager service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants