Skip to content

Conversation

@subham-ibmhc
Copy link
Contributor

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Add resource identity to parameterized resources in cleanrooms. This includes:

aws_cleanrooms_collaboration

Relations

Relates #42983
Relates #42988

Output from Acceptance Testing

% make t T=TestAccCleanRoomsCollaboration_ PKG=cleanrooms
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-ri-cleanrooms 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/cleanrooms/... -v -count 1 -parallel 20 -run='TestAccCleanRoomsCollaboration_'  -timeout 360m -vet=off
2025/12/11 14:02:18 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/11 14:02:18 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccCleanRoomsCollaboration_Identity_Basic
=== PAUSE TestAccCleanRoomsCollaboration_Identity_Basic
=== RUN   TestAccCleanRoomsCollaboration_Identity_RegionOverride
=== PAUSE TestAccCleanRoomsCollaboration_Identity_RegionOverride
=== RUN   TestAccCleanRoomsCollaboration_Identity_ExistingResource
=== PAUSE TestAccCleanRoomsCollaboration_Identity_ExistingResource
=== RUN   TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange
=== RUN   TestAccCleanRoomsCollaboration_basic
=== PAUSE TestAccCleanRoomsCollaboration_basic
=== RUN   TestAccCleanRoomsCollaboration_disappears
=== PAUSE TestAccCleanRoomsCollaboration_disappears
=== RUN   TestAccCleanRoomsCollaboration_mutableProperties
=== PAUSE TestAccCleanRoomsCollaboration_mutableProperties
=== RUN   TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== PAUSE TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== RUN   TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== PAUSE TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== RUN   TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== PAUSE TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== RUN   TestAccCleanRoomsCollaboration_updateMemberAbilities
=== PAUSE TestAccCleanRoomsCollaboration_updateMemberAbilities
=== RUN   TestAccCleanRoomsCollaboration_analyticsEngine
=== PAUSE TestAccCleanRoomsCollaboration_analyticsEngine
=== CONT  TestAccCleanRoomsCollaboration_Identity_Basic
=== CONT  TestAccCleanRoomsCollaboration_mutableProperties
=== CONT  TestAccCleanRoomsCollaboration_updateMemberAbilities
=== CONT  TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange
=== CONT  TestAccCleanRoomsCollaboration_disappears
=== CONT  TestAccCleanRoomsCollaboration_basic
=== CONT  TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== CONT  TestAccCleanRoomsCollaboration_Identity_RegionOverride
=== CONT  TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== CONT  TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== CONT  TestAccCleanRoomsCollaboration_analyticsEngine
=== CONT  TestAccCleanRoomsCollaboration_Identity_ExistingResource
--- PASS: TestAccCleanRoomsCollaboration_disappears (24.46s)
--- PASS: TestAccCleanRoomsCollaboration_basic (29.47s)
--- PASS: TestAccCleanRoomsCollaboration_analyticsEngine (33.00s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_Basic (37.58s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_RegionOverride (39.13s)
--- PASS: TestAccCleanRoomsCollaboration_updateCreatorDisplayName (40.07s)
--- PASS: TestAccCleanRoomsCollaboration_mutableProperties (43.57s)
--- PASS: TestAccCleanRoomsCollaboration_updateQueryLogStatus (46.69s)
--- PASS: TestAccCleanRoomsCollaboration_updateMemberAbilities (47.96s)
--- PASS: TestAccCleanRoomsCollaboration_dataEncryptionSettings (62.39s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange (93.36s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_ExistingResource (102.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cleanrooms 107.385s

% make t T=TestAccCleanRoomsCollaboration_ PKG=cleanrooms
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-ri-cleanrooms 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/cleanrooms/... -v -count 1 -parallel 20 -run='TestAccCleanRoomsCollaboration_'  -timeout 360m -vet=off
2025/12/11 14:02:18 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/11 14:02:18 Initializing Terraform AWS Provider (SDKv2-style)...
=== RUN   TestAccCleanRoomsCollaboration_Identity_Basic
=== PAUSE TestAccCleanRoomsCollaboration_Identity_Basic
=== RUN   TestAccCleanRoomsCollaboration_Identity_RegionOverride
=== PAUSE TestAccCleanRoomsCollaboration_Identity_RegionOverride
=== RUN   TestAccCleanRoomsCollaboration_Identity_ExistingResource
=== PAUSE TestAccCleanRoomsCollaboration_Identity_ExistingResource
=== RUN   TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange
=== PAUSE TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange
=== RUN   TestAccCleanRoomsCollaboration_basic
=== PAUSE TestAccCleanRoomsCollaboration_basic
=== RUN   TestAccCleanRoomsCollaboration_disappears
=== PAUSE TestAccCleanRoomsCollaboration_disappears
=== RUN   TestAccCleanRoomsCollaboration_mutableProperties
=== PAUSE TestAccCleanRoomsCollaboration_mutableProperties
=== RUN   TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== PAUSE TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== RUN   TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== PAUSE TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== RUN   TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== PAUSE TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== RUN   TestAccCleanRoomsCollaboration_updateMemberAbilities
=== PAUSE TestAccCleanRoomsCollaboration_updateMemberAbilities
=== RUN   TestAccCleanRoomsCollaboration_analyticsEngine
=== PAUSE TestAccCleanRoomsCollaboration_analyticsEngine
=== CONT  TestAccCleanRoomsCollaboration_Identity_Basic
=== CONT  TestAccCleanRoomsCollaboration_mutableProperties
=== CONT  TestAccCleanRoomsCollaboration_updateMemberAbilities
=== CONT  TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange
=== CONT  TestAccCleanRoomsCollaboration_disappears
=== CONT  TestAccCleanRoomsCollaboration_basic
=== CONT  TestAccCleanRoomsCollaboration_dataEncryptionSettings
=== CONT  TestAccCleanRoomsCollaboration_Identity_RegionOverride
=== CONT  TestAccCleanRoomsCollaboration_updateQueryLogStatus
=== CONT  TestAccCleanRoomsCollaboration_updateCreatorDisplayName
=== CONT  TestAccCleanRoomsCollaboration_analyticsEngine
=== CONT  TestAccCleanRoomsCollaboration_Identity_ExistingResource
--- PASS: TestAccCleanRoomsCollaboration_disappears (24.46s)
--- PASS: TestAccCleanRoomsCollaboration_basic (29.47s)
--- PASS: TestAccCleanRoomsCollaboration_analyticsEngine (33.00s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_Basic (37.58s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_RegionOverride (39.13s)
--- PASS: TestAccCleanRoomsCollaboration_updateCreatorDisplayName (40.07s)
--- PASS: TestAccCleanRoomsCollaboration_mutableProperties (43.57s)
--- PASS: TestAccCleanRoomsCollaboration_updateQueryLogStatus (46.69s)
--- PASS: TestAccCleanRoomsCollaboration_updateMemberAbilities (47.96s)
--- PASS: TestAccCleanRoomsCollaboration_dataEncryptionSettings (62.39s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange (93.36s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_ExistingResource (102.85s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cleanrooms 107.385s
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍 reaction to the original post to help the community and maintainers prioritize it.
  • Please see our prioritization guide for additional information on how the maintainers handle prioritization.
  • Please do not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. generators Relates to code generators. service/cleanrooms Issues and PRs that pertain to the cleanrooms service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. size/XL Managed by automation to categorize the size of a PR. labels Dec 11, 2025
@subham-ibmhc subham-ibmhc added the rnd-ind-provider rnd-ind-provider label Dec 11, 2025
@subham-ibmhc subham-ibmhc marked this pull request as ready for review December 11, 2025 09:16
@subham-ibmhc subham-ibmhc requested a review from a team as a code owner December 11, 2025 09:16
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make t K=cleanrooms T=TestAccCleanRoomsCollaboration_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-ri-cleanrooms 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/cleanrooms/... -v -count 1 -parallel 20 -run='TestAccCleanRoomsCollaboration_'  -timeout 360m -vet=off
2025/12/11 15:30:10 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/11 15:30:10 Initializing Terraform AWS Provider (SDKv2-style)...

--- PASS: TestAccCleanRoomsCollaboration_disappears (24.73s)
--- PASS: TestAccCleanRoomsCollaboration_basic (29.89s)
--- PASS: TestAccCleanRoomsCollaboration_analyticsEngine (32.73s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_RegionOverride (35.47s)
--- PASS: TestAccCleanRoomsCollaboration_updateCreatorDisplayName (39.59s)
--- PASS: TestAccCleanRoomsCollaboration_updateQueryLogStatus (41.34s)
--- PASS: TestAccCleanRoomsCollaboration_updateMemberAbilities (42.95s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_Basic (43.83s)
--- PASS: TestAccCleanRoomsCollaboration_mutableProperties (47.00s)
--- PASS: TestAccCleanRoomsCollaboration_dataEncryptionSettings (51.46s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange (51.84s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_ExistingResource (54.63s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cleanrooms 61.198s

@jar-b
Copy link
Member

jar-b commented Dec 11, 2025

Omitted a formal approval as this will need rebased and a make copyright-fix run to get the headers converted to the new syntax (as of yesterday).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Introduces or discusses updates to documentation. generators Relates to code generators. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. rnd-ind-provider rnd-ind-provider service/cleanrooms Issues and PRs that pertain to the cleanrooms service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants