-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Add resource identity to aws_cleanrooms_collaboration #45548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
% make t T=TestAccCleanRoomsCollaboration_ PKG=cleanrooms make: Verifying source code with gofmt... ==> Checking that code complies with gofmt requirements... make: Running acceptance tests on branch: 🌿 f-ri-cleanrooms 🌿... TF_ACC=1 go1.24.11 test ./internal/service/cleanrooms/... -v -count 1 -parallel 20 -run='TestAccCleanRoomsCollaboration_' -timeout 360m -vet=off 2025/12/11 14:02:18 Creating Terraform AWS Provider (SDKv2-style)... 2025/12/11 14:02:18 Initializing Terraform AWS Provider (SDKv2-style)... === RUN TestAccCleanRoomsCollaboration_Identity_Basic === PAUSE TestAccCleanRoomsCollaboration_Identity_Basic === RUN TestAccCleanRoomsCollaboration_Identity_RegionOverride === PAUSE TestAccCleanRoomsCollaboration_Identity_RegionOverride === RUN TestAccCleanRoomsCollaboration_Identity_ExistingResource === PAUSE TestAccCleanRoomsCollaboration_Identity_ExistingResource === RUN TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange === PAUSE TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange === RUN TestAccCleanRoomsCollaboration_basic === PAUSE TestAccCleanRoomsCollaboration_basic === RUN TestAccCleanRoomsCollaboration_disappears === PAUSE TestAccCleanRoomsCollaboration_disappears === RUN TestAccCleanRoomsCollaboration_mutableProperties === PAUSE TestAccCleanRoomsCollaboration_mutableProperties === RUN TestAccCleanRoomsCollaboration_updateCreatorDisplayName === PAUSE TestAccCleanRoomsCollaboration_updateCreatorDisplayName === RUN TestAccCleanRoomsCollaboration_updateQueryLogStatus === PAUSE TestAccCleanRoomsCollaboration_updateQueryLogStatus === RUN TestAccCleanRoomsCollaboration_dataEncryptionSettings === PAUSE TestAccCleanRoomsCollaboration_dataEncryptionSettings === RUN TestAccCleanRoomsCollaboration_updateMemberAbilities === PAUSE TestAccCleanRoomsCollaboration_updateMemberAbilities === RUN TestAccCleanRoomsCollaboration_analyticsEngine === PAUSE TestAccCleanRoomsCollaboration_analyticsEngine === CONT TestAccCleanRoomsCollaboration_Identity_Basic === CONT TestAccCleanRoomsCollaboration_mutableProperties === CONT TestAccCleanRoomsCollaboration_updateMemberAbilities === CONT TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange === CONT TestAccCleanRoomsCollaboration_disappears === CONT TestAccCleanRoomsCollaboration_basic === CONT TestAccCleanRoomsCollaboration_dataEncryptionSettings === CONT TestAccCleanRoomsCollaboration_Identity_RegionOverride === CONT TestAccCleanRoomsCollaboration_updateQueryLogStatus === CONT TestAccCleanRoomsCollaboration_updateCreatorDisplayName === CONT TestAccCleanRoomsCollaboration_analyticsEngine === CONT TestAccCleanRoomsCollaboration_Identity_ExistingResource --- PASS: TestAccCleanRoomsCollaboration_disappears (24.46s) --- PASS: TestAccCleanRoomsCollaboration_basic (29.47s) --- PASS: TestAccCleanRoomsCollaboration_analyticsEngine (33.00s) --- PASS: TestAccCleanRoomsCollaboration_Identity_Basic (37.58s) --- PASS: TestAccCleanRoomsCollaboration_Identity_RegionOverride (39.13s) --- PASS: TestAccCleanRoomsCollaboration_updateCreatorDisplayName (40.07s) --- PASS: TestAccCleanRoomsCollaboration_mutableProperties (43.57s) --- PASS: TestAccCleanRoomsCollaboration_updateQueryLogStatus (46.69s) --- PASS: TestAccCleanRoomsCollaboration_updateMemberAbilities (47.96s) --- PASS: TestAccCleanRoomsCollaboration_dataEncryptionSettings (62.39s) --- PASS: TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange (93.36s) --- PASS: TestAccCleanRoomsCollaboration_Identity_ExistingResource (102.85s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/cleanrooms 107.385s
Community GuidelinesThis comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀 Voting for Prioritization
Pull Request Authors
|
internal/service/cleanrooms/testdata/tmpl/collaboration_tags.gtpl
Outdated
Show resolved
Hide resolved
jar-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make t K=cleanrooms T=TestAccCleanRoomsCollaboration_
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
make: Running acceptance tests on branch: 🌿 f-ri-cleanrooms 🌿...
TF_ACC=1 go1.24.11 test ./internal/service/cleanrooms/... -v -count 1 -parallel 20 -run='TestAccCleanRoomsCollaboration_' -timeout 360m -vet=off
2025/12/11 15:30:10 Creating Terraform AWS Provider (SDKv2-style)...
2025/12/11 15:30:10 Initializing Terraform AWS Provider (SDKv2-style)...
--- PASS: TestAccCleanRoomsCollaboration_disappears (24.73s)
--- PASS: TestAccCleanRoomsCollaboration_basic (29.89s)
--- PASS: TestAccCleanRoomsCollaboration_analyticsEngine (32.73s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_RegionOverride (35.47s)
--- PASS: TestAccCleanRoomsCollaboration_updateCreatorDisplayName (39.59s)
--- PASS: TestAccCleanRoomsCollaboration_updateQueryLogStatus (41.34s)
--- PASS: TestAccCleanRoomsCollaboration_updateMemberAbilities (42.95s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_Basic (43.83s)
--- PASS: TestAccCleanRoomsCollaboration_mutableProperties (47.00s)
--- PASS: TestAccCleanRoomsCollaboration_dataEncryptionSettings (51.46s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_ExistingResource_NoRefresh_NoChange (51.84s)
--- PASS: TestAccCleanRoomsCollaboration_Identity_ExistingResource (54.63s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/cleanrooms 61.198s|
Omitted a formal approval as this will need rebased and a |
Rollback Plan
If a change needs to be reverted, we will publish an updated version of the library.
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
Description
Add resource identity to parameterized resources in
cleanrooms. This includes:aws_cleanrooms_collaboration
Relations
Relates #42983
Relates #42988
Output from Acceptance Testing