Skip to content

ResourceIdentity: Fix API group names missing .k8s.io suffix #2755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025
Merged

ResourceIdentity: Fix API group names missing .k8s.io suffix #2755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kubernetes/resource_kubernetes_ingress_class_v1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ func resourceKubernetesIngressClassV1Create(ctx context.Context, d *schema.Resou
log.Printf("[INFO] Submitted new IngressClass: %#v", out)
d.SetId(out.ObjectMeta.GetName())

err = setResourceIdentityNonNamespaced(d, "networking/v1", "IngressClass", out.GetName())
err = setResourceIdentityNonNamespaced(d, "networking.k8s.io/v1", "IngressClass", out.GetName())
if err != nil {
return diag.FromErr(err)
}
Expand Down Expand Up @@ -156,7 +156,7 @@ func resourceKubernetesIngressClassV1Read(ctx context.Context, d *schema.Resourc
return diag.FromErr(err)
}

err = setResourceIdentityNonNamespaced(d, "networking/v1", "IngressClass", ing.GetName())
err = setResourceIdentityNonNamespaced(d, "networking.k8s.io/v1", "IngressClass", ing.GetName())
if err != nil {
return diag.FromErr(err)
}
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/resource_kubernetes_ingress_class_v1_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ func TestAccKubernetesIngressClassV1_identity(t *testing.T) {
statecheck.ExpectIdentity(
resourceName, map[string]knownvalue.Check{
"name": knownvalue.StringExact(name),
"api_version": knownvalue.StringExact("networking/v1"),
"api_version": knownvalue.StringExact("networking.k8s.io/v1"),
"kind": knownvalue.StringExact("IngressClass"),
},
),
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/resource_kubernetes_ingress_v1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ func resourceKubernetesIngressV1Read(ctx context.Context, d *schema.ResourceData
return diag.FromErr(err)
}

err = setResourceIdentityNamespaced(d, "networking/v1", "Ingress", namespace, name)
err = setResourceIdentityNamespaced(d, "networking.k8s.io/v1", "Ingress", namespace, name)
if err != nil {
return diag.FromErr(err)
}
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/resource_kubernetes_ingress_v1_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,7 +398,7 @@ func TestAccKubernetesIngressV1_identity(t *testing.T) {
resourceName, map[string]knownvalue.Check{
"namespace": knownvalue.StringExact("default"),
"name": knownvalue.StringExact(name),
"api_version": knownvalue.StringExact("networking/v1"),
"api_version": knownvalue.StringExact("networking.k8s.io/v1"),
"kind": knownvalue.StringExact("Ingress"),
},
),
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/resource_kubernetes_mutating_webhook_configuration_v1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ func resourceKubernetesMutatingWebhookConfigurationV1Read(ctx context.Context, d
return diag.FromErr(err)
}

err = setResourceIdentityNonNamespaced(d, "admissionregistration/v1", "MutatingWebhookConfiguration", name)
err = setResourceIdentityNonNamespaced(d, "admissionregistration.k8s.io/v1", "MutatingWebhookConfiguration", name)
if err != nil {
return diag.FromErr(err)
}
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/resource_kubernetes_mutating_webhook_configuration_v1_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ func TestAccKubernetesMutatingWebhookConfigurationV1_identity(t *testing.T) {
statecheck.ExpectIdentity(
resourceName, map[string]knownvalue.Check{
"name": knownvalue.StringExact(name),
"api_version": knownvalue.StringExact("admissionregistration/v1"),
"api_version": knownvalue.StringExact("admissionregistration.k8s.io/v1"),
"kind": knownvalue.StringExact("MutatingWebhookConfiguration"),
},
),
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/resource_kubernetes_network_policy_v1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ func resourceKubernetesNetworkPolicyV1Read(ctx context.Context, d *schema.Resour
if err != nil {
return diag.FromErr(err)
}
err = setResourceIdentityNamespaced(d, "networking/v1", "NetworkPolicy", namespace, name)
err = setResourceIdentityNamespaced(d, "networking.k8s.io/v1", "NetworkPolicy", namespace, name)
if err != nil {
return diag.FromErr(err)
}
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/resource_kubernetes_network_policy_v1_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ func TestAccKubernetesNetworkPolicyV1_identity(t *testing.T) {
resourceName, map[string]knownvalue.Check{
"namespace": knownvalue.StringExact("default"),
"name": knownvalue.StringExact(name),
"api_version": knownvalue.StringExact("networking/v1"),
"api_version": knownvalue.StringExact("networking.k8s.io/v1"),
"kind": knownvalue.StringExact("NetworkPolicy"),
},
),
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/resource_kubernetes_validating_webhook_configuration_v1.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ func resourceKubernetesValidatingWebhookConfigurationV1Read(ctx context.Context,
return diag.FromErr(err)
}

err = setResourceIdentityNonNamespaced(d, "admissionregistration/v1", "ValidatingWebhookConfiguration", name)
err = setResourceIdentityNonNamespaced(d, "admissionregistration.k8s.io/v1", "ValidatingWebhookConfiguration", name)
if err != nil {
return diag.FromErr(err)
}
Expand Down
2 changes: 1 addition & 1 deletion kubernetes/resource_kubernetes_validating_webhook_configuration_v1_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ func TestAccKubernetesValidatingWebhookConfigurationV1_identity(t *testing.T) {
statecheck.ExpectIdentity(
resourceName, map[string]knownvalue.Check{
"name": knownvalue.StringExact(name),
"api_version": knownvalue.StringExact("admissionregistration/v1"),
"api_version": knownvalue.StringExact("admissionregistration.k8s.io/v1"),
"kind": knownvalue.StringExact("ValidatingWebhookConfiguration"),
},
),
Expand Down
Loading