Skip to content

Decouple node-canvas dependency from the main package. #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Decouple node-canvas dependency from the main package. #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ebc85e
remove npm canvas dependency from the main package, create a separate…
virbas May 10, 2023
f800ba7
update readme for node-canvas version
virbas May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/nodejs/node-canvas/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
## Example script how to create offline .mind target files
A original version of generating .mind files using node (previously was `examples/nodejs/createImageTargetLibrary.js`) now in it's own package.
7 changes: 5 additions & 2 deletions examples/nodejs/createImageTargetLibrary.js → examples/nodejs/node-canvas/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
import { OfflineCompiler } from '../../src/image-target/offline-compiler.js';
import { OfflineCompiler } from './offline-compiler.js';

import { writeFile } from 'fs/promises'
import { loadImage } from 'canvas';

console.time('execution time');

//canvas.loadImage treats path as relative from where nodejs was executed, not relative to the script's location
const imagePaths = ['examples/image-tracking/assets/card-example/card.png'];
const imagePaths = ['../../../examples/image-tracking/assets/card-example/card.png'];

async function run() {
//load all images
Expand All @@ -13,6 +15,7 @@ async function run() {
await compiler.compileImageTargets(images, console.log);
const buffer = compiler.exportData();
await writeFile('targets.mind', buffer);
console.timeEnd('execution time');
}


Expand Down
8 changes: 4 additions & 4 deletions src/image-target/offline-compiler.js → ...es/nodejs/node-canvas/offline-compiler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import {CompilerBase} from './compiler-base.js'
import { buildTrackingImageList } from './image-list.js';
import { extractTrackingFeatures } from './tracker/extract-utils.js';
import {CompilerBase} from '../../../src/image-target/compiler-base.js'
import { buildTrackingImageList } from '../../../src/image-target/image-list.js';
import { extractTrackingFeatures } from '../../../src/image-target/tracker/extract-utils.js';
import { createCanvas } from 'canvas'
import './detector/kernels/cpu/index.js'
import '../../../src/image-target/detector/kernels/cpu/index.js'

export class OfflineCompiler extends CompilerBase {
createProcessCanvas(img) {
Expand Down
Loading