Skip to content

Fix TabBarMinimize and prefersLargeTitle behaviour #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+28 −1
Open

Fix TabBarMinimize and prefersLargeTitle behaviour #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aa5c7e
Fix TabBarMinimize behaviour on visit
nbelzer Oct 24, 2025
ecf3313
Add VisitableView subview ordering tests
nbelzer Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Source/Turbo/Visitable/VisitableView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@ open class VisitableView: UIView {
open func activateWebView(_ webView: WKWebView, forVisitable visitable: Visitable) {
self.webView = webView
self.visitable = visitable
addSubview(webView)
// For behaviour like UINavigationBar.prefersLargeTitles or
// TabBarMinimize to work the scrollable view shoud be the
// first child in the hierarchy from the moment it is added.
insertSubview(webView, at: 0)
addFillConstraints(for: webView)
installRefreshControl()
showOrHideWebView()
Expand Down
24 changes: 24 additions & 0 deletions Tests/Turbo/VisitableViewControllerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,30 @@ class VisitableViewControllerTests: XCTestCase {
XCTAssertEqual(viewController.initialVisitableURL, originalURL)
XCTAssertEqual(viewController.currentVisitableURL, overriddenURL)
}

func test_webview_is_first_child_during_loading() {
XCTAssertEqual(viewController.visitableView.subviews.first, viewController.visitableView.activityIndicatorView)

viewController.visitableView.activateWebView(webView, forVisitable: viewController)

XCTAssertEqual(viewController.visitableView.subviews.first, webView)
XCTAssertEqual(viewController.visitableView.subviews.last, viewController.visitableView.activityIndicatorView)
}

func test_webview_is_first_child_on_restore() {
XCTAssertEqual(viewController.visitableView.subviews.first, viewController.visitableView.activityIndicatorView)

viewController.showVisitableScreenshot()
viewController.visitableView.activateWebView(webView, forVisitable: viewController)

XCTAssertEqual(viewController.visitableView.subviews.count, 3)
XCTAssertEqual(viewController.visitableView.subviews.first, viewController.visitableView.webView)

viewController.hideVisitableScreenshot()

XCTAssertEqual(viewController.visitableView.subviews.count, 2)
XCTAssertEqual(viewController.visitableView.subviews.first, viewController.visitableView.webView)
}
}

final class WebViewSpy: WKWebView {
Expand Down
Loading