Call Visit#fail when reloading due to request failure
#1332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you fix the linting issues please? |
Author
|
@brunoprietog I have fixed the issues. |
seanpdoyle
force-pushed
the
call_visit_fail_when_reloading_due_to_request_failure
branch
2 times, most recently
from
1bc5701 to
a8a2ee2
Compare
seanpdoyle
requested changes
Nov 11, 2025
| }) | ||
|
|
||
|
|
||
| test.only("hides progress bar when reloading due to request failure", async ({ page }) => { |
Contributor
There was a problem hiding this comment.
Could you remove the .only call?
Suggested change
| test.only("hides progress bar when reloading due to request failure", async ({ page }) => { | |
| test("hides progress bar when reloading due to request failure", async ({ page }) => { |
Comment on lines
+588
to
+591
| await page.waitForEvent('download') | ||
|
|
||
| await waitUntilNoSelector(page, ".turbo-progress-bar") | ||
| assert.notOk(await hasSelector(page, ".turbo-progress-bar"), "hides progress bar") |
Contributor
There was a problem hiding this comment.
If you rebase this branch, you'll be able to re-write this assertion using Playwright's expect assertions:
Suggested change
| await page.waitForEvent('download') | |
| await waitUntilNoSelector(page, ".turbo-progress-bar") | |
| assert.notOk(await hasSelector(page, ".turbo-progress-bar"), "hides progress bar") | |
| await page.waitForEvent("download") | |
| await expect(page.locator(".turbo-progress-bar"), "hides progress bar").not.toBeAttached() |
Comment on lines
-46
to
+52
| return this.reload({ | ||
| this.reload({ | ||
| reason: "request_failed", | ||
| context: { | ||
| statusCode | ||
| } | ||
| }) | ||
| return visit.fail() |
Contributor
There was a problem hiding this comment.
If I execute this branch locally with the changes in this file reverted, the tests still pass.
Can you help me understand how this change is related to the test coverage you've added?
How is a call to visit.fail() related to clicking an <a> element to download a file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a problem in which the progress bar progresses after the download is completed when the link does not have the
downloadattribute.2024-10-25.17.31.27.mov